Skip to content

Tests: fix valgrind complaints regarding open file descriptors - #1554

Merged
val-ms merged 1 commit into
Cisco-Talos:mainfrom
val-ms:clamd-clamav-unit-tests
Sep 9, 2025
Merged

Tests: fix valgrind complaints regarding open file descriptors#1554
val-ms merged 1 commit into
Cisco-Talos:mainfrom
val-ms:clamd-clamav-unit-tests

Conversation

@val-ms

@val-ms val-ms commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

Fix valgrind issues regarding:

  • Unclosed log file descriptor in libclamav unit test program.
    Also need to disable debug logging for iconv_cache_destroy() for this
    or else it will try to use that file descriptor after main() exits.

  • Unclosed socket file descriptor in ClamDScan when doing ping()
    function.

CLAM-2872

@val-ms
val-ms force-pushed the clamd-clamav-unit-tests branch from de25cef to 44b3a91 Compare August 19, 2025 04:01
Comment thread clamdscan/client.c Outdated
jhumlick
jhumlick previously approved these changes Aug 19, 2025
@val-ms
val-ms force-pushed the clamd-clamav-unit-tests branch from 44b3a91 to 0c45e5c Compare August 19, 2025 23:06
Comment thread clamdscan/client.c Outdated
jhumlick
jhumlick previously approved these changes Sep 2, 2025
Fix valgrind issues regarding:

- Unclosed log file descriptor in libclamav unit test program.
  Also need to disable debug logging for `iconv_cache_destroy()` for this
  or else it will try to use that file descriptor after `main()` exits.

- Unclosed socket file descriptor in ClamDScan when doing `ping()`
  function.

CLAM-2872
@val-ms
val-ms force-pushed the clamd-clamav-unit-tests branch from 8822a8f to 149c721 Compare September 5, 2025 21:27
@val-ms
val-ms merged commit d758c00 into Cisco-Talos:main Sep 9, 2025
22 of 24 checks passed
@val-ms
val-ms deleted the clamd-clamav-unit-tests branch September 9, 2025 16:35
jhumlick pushed a commit to jhumlick/clamav that referenced this pull request Nov 4, 2025
Fix valgrind issues regarding:

- Unclosed log file descriptor in libclamav unit test program.
  Also need to disable debug logging for `iconv_cache_destroy()` for this
  or else it will try to use that file descriptor after `main()` exits.

- Unclosed socket file descriptor in ClamDScan when doing `ping()`
  function.

CLAM-2872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants