Some fixes for GNU/Hurd - #1555
Merged
Merged
Conversation
Contributor
|
Thanks for your PR. Will review soon. It won't make it into the 1.5.0 release candidate though, which we're preparing to publish tomorrow. |
Set a C_GNU_HURD CMake variable for Hurd, matching the existing #define in clamav-config.h; use it to set _GNU_SOURCE, which is correct for GNU systems.
Rather than trying to read /etc/release, which is specific to Solaris.
setrlimit() is a POSIX API; while it can be used in more places, expand its usage to any platform based on GNU libc.
val-ms
approved these changes
Aug 30, 2025
val-ms
left a comment
val-ms
left a comment
Contributor
There was a problem hiding this comment.
I'm okay with these changes. I can't test them on GNU/Hurd but I did verify they don't break anything in our test pipelines. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides some fixes needed to help making clamav build again on GNU/Hurd, like it used to in the past:
lsb_releaseas diagnosticThere are a couple more fixes needed; this is a good part of the changes needed.