When loading a CVD, skip .info file DSIG check if used .sign file - #1558
Closed
val-ms wants to merge 1 commit into
Closed
When loading a CVD, skip .info file DSIG check if used .sign file#1558val-ms wants to merge 1 commit into
val-ms wants to merge 1 commit into
Conversation
If a CVD was verified using a `.sign` file, there's no need to verify the legacy SHA2-256-based RSA DSIG when loading the `.info` file. In this commit, I've reused the old `CL_DB_ENHANCED` flag to indicate if a CVD was verified using the `.sign` file. This differentiates from using the `CL_DB_SIGNED` flag, which is used for the weaker MD5-based RSA DSIG that would be found within a CVD header. This gets ClamAV away from requiring the legacy CVD DSIG capability so that in the future we might publish CVD's which *only* have the more modern external `.sign` digital signatures. CLAM-2851
Contributor
Author
|
Augh realized a mistake. Will close and revisit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a CVD was verified using a
.signfile, there's no need to verify the legacy SHA2-256-based RSA DSIG when loading the.infofile.In this commit, I've reused the old
CL_DB_ENHANCEDflag to indicate if a CVD was verified using the.signfile. This differentiates from using theCL_DB_SIGNEDflag, which is used for the weaker MD5-based RSA DSIG that would be found within a CVD header.This gets ClamAV away from requiring the legacy CVD DSIG capability so that in the future we might publish CVD's which only have the more modern external
.signdigital signatures.CLAM-2851