FreshClam: use the configured outdated hook in daemon mode - #1770
Open
val-ms wants to merge 1 commit into
Open
Conversation
FreshClam's non-daemon update path passes OnOutdatedExecute to the database update helper when the outdated-version hook is enabled. The daemon update loop checked the OnOutdatedExecute option but accidentally passed the OnUpdateExecute command string instead. This could cause daemon-mode outdated-version events to run the update hook, or to run no hook when only OnOutdatedExecute was configured. Pass the OnOutdatedExecute command string in the daemon path so both update modes use the same hook selection. Credit: Nir Yehoshua, Cipher Security Labs CLAM-3025
There was a problem hiding this comment.
Pull request overview
This PR fixes FreshClam’s daemon-mode update loop to pass the correct configured “outdated version” hook (OnOutdatedExecute) into perform_database_update(), matching the already-correct non-daemon behavior and ensuring outdated-version events don’t incorrectly run the update hook.
Changes:
- In daemon mode, pass
OnOutdatedExecute(notOnUpdateExecute) as theonOutdatedExecuteparameter toperform_database_update(). - Preserve the non-daemon update path behavior (already correct).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jhumlick
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnOutdatedExecuteto the database update helper when the outdated-version hook is enabled.Rationale
The non-daemon update path correctly passes
OnOutdatedExecutewhen the outdated hook is configured. The daemon loop checked whetherOnOutdatedExecutewas enabled, but accidentally passed theOnUpdateExecutecommand string. That could cause daemon-mode outdated-version events to run the update hook, or to run no hook when onlyOnOutdatedExecutewas configured.Validation
git diff --checkcmake --build build --target freshclam-bin -j12Credit
Reported by Nir Yehoshua, Cipher Security Labs.