fix(signatures): use origin URL basename for remote .sign downloads - #92
Open
dragoangel wants to merge 2 commits into
Open
fix(signatures): use origin URL basename for remote .sign downloads#92dragoangel wants to merge 2 commits into
dragoangel wants to merge 2 commits into
Conversation
- decouple remote signature filename from local DB alias - derive remote sign name from origin URL path, preserving versioned naming - keep local save path as <local-db-name>.sign - add regression coverage for local-name vs origin-name behavior - harden test isolation with mocked HTTP and socket-level network guard Signed-off-by: Dmytro Alieksieiev <1865999+dragoangel@users.noreply.github.com>
dragoangel
force-pushed
the
fix-sign-download
branch
from
July 12, 2026 01:46
08624c0 to
546b8b2
Compare
Contributor
Author
|
Hi @val-ms, could you please review this PR when you have a moment? This fixes an important issue in signature handling for mirrored databases with custom local names. Before this change, the downloader could build the remote .sign filename from the local alias instead of the origin filename, which can cause signature downloads to fail or mismatch in real mirror setups. This fix also covers proper cleanup for diffs retention and database delete logic. P.s. also it would be good to release 1.3.0 before merging this PR and 1.3.1 - right after, as currently cvdupdate latest version is still 1.2.0, otherwise I need to include all my changes into 1.3.0. |
Signed-off-by: Dmytro Alieksieiev <1865999+dragoangel@users.noreply.github.com>
dragoangel
force-pushed
the
fix-sign-download
branch
from
July 13, 2026 12:20
fa8ceac to
7bc93c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.