Skip to content

fix(signatures): use origin URL basename for remote .sign downloads - #92

Open
dragoangel wants to merge 2 commits into
Cisco-Talos:mainfrom
dragoangel:fix-sign-download
Open

fix(signatures): use origin URL basename for remote .sign downloads#92
dragoangel wants to merge 2 commits into
Cisco-Talos:mainfrom
dragoangel:fix-sign-download

Conversation

@dragoangel

@dragoangel dragoangel commented Jul 12, 2026

Copy link
Copy Markdown
Contributor
  • decouple remote signature filename from local DB alias
  • derive remote sign name from origin URL path, preserving versioned naming
  • keep local save path as .sign
  • add regression coverage for local-name vs origin-name behavior
  • harden test isolation with mocked HTTP and socket-level network guard
  • remove sign files on cdiff retention
  • remove sign files on database removal, including sign for cdiff versions

- decouple remote signature filename from local DB alias
- derive remote sign name from origin URL path, preserving versioned naming
- keep local save path as <local-db-name>.sign
- add regression coverage for local-name vs origin-name behavior
- harden test isolation with mocked HTTP and socket-level network guard

Signed-off-by: Dmytro Alieksieiev <1865999+dragoangel@users.noreply.github.com>
@dragoangel

dragoangel commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

Hi @val-ms, could you please review this PR when you have a moment?

This fixes an important issue in signature handling for mirrored databases with custom local names. Before this change, the downloader could build the remote .sign filename from the local alias instead of the origin filename, which can cause signature downloads to fail or mismatch in real mirror setups.

This fix also covers proper cleanup for diffs retention and database delete logic.

P.s. also it would be good to release 1.3.0 before merging this PR and 1.3.1 - right after, as currently cvdupdate latest version is still 1.2.0, otherwise I need to include all my changes into 1.3.0.

Signed-off-by: Dmytro Alieksieiev <1865999+dragoangel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant