Updated Exablaze trailer to only use hueristic when required #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the current version, where the heuristic method of decoding Exablaze HPT trailers is invoked, even if the user specifies the --trailer on the command line. This can break if the PCAP headers are taken on an ExaNIC that has not be sync'd using exanic-clock-sync. In this case, there will be a large discrepancy between the PCAP header time, and the HPT trailer time. But, the contents of the HPT trailer is still fine.
This PR fixes the bug by adding a "forced" mode to the code path. If the user specifies --trailer, then the trailer is assumed to reside at the end of the frame with no extra bytes.