Added ability to un-deploy non-application template types in resource_ndo_schema_template_deploy (DCNE-583) #407
Conversation
…pes in resource_ndo_schema_template_deploy
shrsr
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
samiib
as code owners
github-actions
bot
changed the title
| } | ||
|
|
||
| // Get site IDs from deploySummary | ||
| siteDeployments, err := template.S("deploySummmary", "siteDeploymentSummaries").Children() |
There was a problem hiding this comment.
I used a similar method to get the deployment task ids in CiscoDevNet/ansible-mso#728. How likely do we think the API will change to fix the deploySummmary typo here?
There was a problem hiding this comment.
I'm not sure. We'll cross that bridge when we get there I suppose? Also not sure on what would happen to the endpoint with the typo if they just came up with a new API endpoint? We could open a case with the Engg. for this? Could you ask @lhercot ?
| }, | ||
| }, | ||
|
|
||
| "undeploy": &schema.Schema{ |
There was a problem hiding this comment.
Should we have an undeploy_all option like we added in ansible? Then both integrations will have similar behaviour.
site_ids would be required on undeploy and ignored on undeploy_all
There was a problem hiding this comment.
@samiib Yes, that's the plan. I'm still working on this PR because I need to implement un-deploying application type templates as well.
2 participants
No description provided.