-
Notifications
You must be signed in to change notification settings - Fork 420
Handle NTP servers configured to use a key #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle NTP servers configured to use a key #964
Conversation
ThomasJRyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fine change, just needs some maintenance.
Along with the requested changes, it will need a changelog file and unittests.
You can look to close PRs to get a sense of what they should be, but for a quick example
Changelogs are .rst files placed into genieparser/changelog/undistributed with the format
---------------------------------
Fix
---------------------------------
* <OS>
* <Parser Class Name>
* <A brief description of what was changed>
And unittests consist of two files inside of the tests/<name_of_parser_class> folder. A <name>_output.txt file with the raw output of the command, and a <name>_expected.py file that contains a single variable called expected_output which should be equal to the resulting parsed dictionary.
Include all that and this is good to go! (I know it's a bit of a process, but I promise you it gets easier with time)
ThomasJRyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change to the changelog and all is good to go
changelog/undistributed/changelog_show_ntp_configuration_iosxe_202510271000.rst
Show resolved
Hide resolved
…_202510271000.rst
|
the pipeline seems to fail |
My output was the result of using this parser as part of a 'learn("ntp")', it seems that output differs from a straight parsing of just "show ntp config". I will update |
Description
Handle NTP servers configured to use a key
eg:
ntp server vrf Mgmt 10.2.2.2 key 2
ntp server vrf Mgmt 10.3.3.3 key 3 prefer
Motivation and Context
NTP servers that have a key configured are not properly parsed by the current regex
Impact (If any)
NTP servers that have a key configured are properly parsed
Screenshots:
Checklist: