use verb macro for defining some admin verbs + realias tg ones#7508
use verb macro for defining some admin verbs + realias tg ones#7508LetterN wants to merge 3 commits intoCitadel-Station-13:masterfrom
Conversation
| @@ -0,0 +1,40 @@ | |||
| // Re-aliased tg defines | |||
There was a problem hiding this comment.
don't realias macros if it just does the same thing
for context only just add a def that just nulls it
also, there's no need to replace the verb categories unless we're going to get a statpanel that doesn't treat them as verbs; they're all verbs internally, thus they are verb categories.
stuff like profile/ipintel should not be their own tabs, statpanel if needed should just parse the category like Category.Subcategory or something
rest of PR is fine but this is duplicate
There was a problem hiding this comment.
license
also category is just a rename
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ two week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About The Pull Request
Adds tg
ADMIN_VERBalias among other things (i just want to use their naming scheme).verb__invoke_##PATH_SUFFIX(client/user, ##HEADER)is now user instead of invokingalso
debug_controllernow does not lie, it debugs controllers not subsystems.Why It's Good For The Game
Changelog