Initial secondary context introduction. Doesn't build yet.#405
Draft
moonheart08 wants to merge 1 commit intotake2from
Draft
Initial secondary context introduction. Doesn't build yet.#405moonheart08 wants to merge 1 commit intotake2from
moonheart08 wants to merge 1 commit intotake2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical details
This introduces a new pair of db contexts meant for Citadel-specific model data. This model lives separately from the upstream model, which means we (currently I) can use cleaner practices with it to our heart's content.
This also removes all of upstream's migrations and squashes them back into a single initialize. This removes compatibility with databases initialized off upstream but this is imo fine. Upstream's model is modified to have a default schema (
ss14) while Citadel's usescitadel.Some amount of changes are done to upstream's db code in an effort to generalize it. Some over-abstraction is removed.