-
Notifications
You must be signed in to change notification settings - Fork 7
PNE-6482 Support default_labels
in MaterialRun constructor
#989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cf8dea5
to
3c33bf1
Compare
default_labels
in MaterialRun constructordefault_labels
in MaterialRun constructor
3c33bf1
to
4617536
Compare
Why is this being update here and not in https://github.com/CitrineInformatics/gemd-python/blob/main/gemd/entity/template/material_template.py? Nominally, that's where the data structure is inherited from. |
This seemed to be the most directly equivalent to the logic that was added in https://github.com/CitrineInformatics/platform-backend/pull/5021 to support the design-over-untested-ingredients functionality via UI ingest -- adding the generated tags to the material run. Since we don't add tags to the material template in that workflow I think it probably makes sense to limit the scope of this change as well, but I'm open to reconsidering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fit for purpose. Some stylistic feedback to be provided off-line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the additional tests.
This update is analagous to the one in #989 The associated utility function and test have been moved to a shared module, and the documentation has been updated
This update is analagous to the one in #989 The associated utility function and test have been moved to a shared module, and the documentation has been updated
Citrine Python PR
PNE-6482
Support
default_labels
in MaterialRun constructorThis PR adds support for a new optional
default_labels: List[str]
parameter in the MaterialRun constructor.Default labels are used to:
PR Type:
Adherence to team decisions