Conversation
…6-6367, CVE-2026-6366
We were having trouble where the correct street name was cut off at intersections. This change returns more street name results, which is bettern that some streets sometimes missing.
045e615 to
ec616d5
Compare
…lete This replaces service map autocomplete in the react app, since paikkatieto api and service map data have slight differences. Any difference in street names makes the street unsearchable, since we match the names with keyword search.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



UHF-13035
What was done
Added a new Search API index for street names from the Paikkatieto API into Elasticsearch for vehicle removal search autocomplete. Previously, autocomplete suggestions came from the Service Map API, which had inconsistent street name spellings compared to the Paikkatieto data used in the actual search results. Since the results query uses an exact terms match on street names, mismatches like "Tarkk'ampujankatu" vs "Tarkka-ampujankatu" made those streets unsearchable. Using the same source for both autocomplete and results guarantees the names match.
In addition, refactored PaikkatietoClient: removed distance-based closest-street filtering in favor of returning all street names within a configurable search radius. This should fix inconsistent results in intersections with the drawback of returning more "nearby" results.
How to install
git checkout dev && git pull origin devmake freshgit fetch && git checkout UHF-13035composer require drupal/hdbt:dev-UHF-13035make drush-deploySee: https://helsinkisolutionoffice.atlassian.net/wiki/spaces/HEL/pages/8354005224/Tunnusten+salasanojen+ja+muiden+avainten+jakaminen.
How to test
drush sapi-rt mobilenote_data; drush sapi-i mobilenote_data --limit 100drush sapi-rt paikkatieto_street_names; drush sapi-i paikkatieto_street_namesLinks to related PRs