Skip to content

UHF-11656: Numbers highlight paragraph#941

Merged
teroelonen merged 18 commits intomainfrom
UHF-11656
Apr 24, 2025
Merged

UHF-11656: Numbers highlight paragraph#941
teroelonen merged 18 commits intomainfrom
UHF-11656

Conversation

@annadruid
Copy link
Copy Markdown
Contributor

@annadruid annadruid commented Apr 11, 2025

UHF-11656

What was done

  • Created and added new paragraph Number Highlights to basic page, landing page, news_article, district and project page
  • Added character counter for number and text and support for multifield for the counter

How to install

Test in Etusivu and in KYMP and in some non-core site

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • In you're instances (Etusivu and KYMP) run git checkout UHF-11656
  • Update the HDBT Admin theme, HDBT theme and the Helfi Platform config
    • composer require drupal/hdbt_admin:dev-UHF-11656 drupal/hdbt:dev-UHF-11656 drupal/helfi_platform_config:dev-UHF-11656
  • Run make drush-updb drush-locale-update drush-cr

How to test

In Etusivu:

  • Add number highlights to basic page upper and lower content regions, create also a basic page that has content in the sidebar and add the number highlights paragraph to both upper and lower content regions
  • Make sure that the styles match the design here
  • Make sure that you're also able to add the paragraph to news_article (Artikkeli) and landing page
  • Make sure the translations for the paragraph and its fields work in Finnish and English

In KYMP

  • Make sure that you're able to add the paragraph to district upper and lower content regions and on project page to upper content region
  • should also be available on basic page and landing page

Some non-core site

  • Test that the paragraph is available on basic and landing page
  • Check that code follows our standards

Other PRs

@annadruid annadruid marked this pull request as draft April 11, 2025 05:41
@hyrsky hyrsky force-pushed the UHF-11656 branch 3 times, most recently from f29b296 to 706ce71 Compare April 16, 2025 11:27
@annadruid annadruid marked this pull request as ready for review April 17, 2025 04:30
Copy link
Copy Markdown
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one has an issue that causes WSOD: If you insert 7 numbers to the number field.

Copy link
Copy Markdown
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WSOD issue has been fixed and now this works nicely 🦖

@sonarqubecloud
Copy link
Copy Markdown

@teroelonen teroelonen merged commit 609ca47 into main Apr 24, 2025
7 checks passed
@teroelonen teroelonen deleted the UHF-11656 branch April 24, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants