Skip to content

Modernize styling structure and fix component imports #920

Merged
nikomakela merged 4 commits into
mainfrom
LIIKUNTA-768-fix-style-imports
Nov 24, 2025
Merged

Modernize styling structure and fix component imports #920
nikomakela merged 4 commits into
mainfrom
LIIKUNTA-768-fix-style-imports

Conversation

@nikomakela

Copy link
Copy Markdown
Contributor

LIIKUNTA-768

Several architectural improvements and necessary fixes related to styling, component imports, and exports.

The changes aim to clean up the codebase, leverage modern SCSS features, and ensure compatibility with build environments like Turbopack.

  1. Removes unnecessary, unused, or redundant Sass files from the application directory, contributing to a cleaner codebase.
  2. Refactors style imports to utilize the Sass @forward rule, allowing us to better manage and share variables, mixins, and configuration across different modules.
  3. Moves the application's global CSS import to the top-level App component. This resolves warnings (e.g., from Turbopack) which enforce that global stylesheets must only be imported in the main App component to prevent conflicts and ensure predictable styling.
  4. Corrects the export statement for the BaseApp Fallback component, ensuring it is properly available for consumption throughout the application.

LIIKUNTA-768.

Using Turbopack makes it clear that global stylesheets can only be
imported in App component.

When running app with a Turbopack, a following warning is printed in
terminal:

```shell
Global CSS cannot be imported from files other than your Custom <App>.
Due to the Global nature of stylesheets, and to avoid conflicts, Please
move all first-party global CSS imports to pages/_app.js. Or convert the
import to Component-Level CSS (CSS Modules).
```
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@terovirtanen

Copy link
Copy Markdown
Contributor

FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-hobbies-pr920.dev.hel.ninja 🚀🚀🚀

@terovirtanen

Copy link
Copy Markdown
Contributor

FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-events-pr920.dev.hel.ninja 🚀🚀🚀

@terovirtanen

Copy link
Copy Markdown
Contributor

FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-sports-pr920.dev.hel.ninja 🚀🚀🚀

@terovirtanen

Copy link
Copy Markdown
Contributor

VENUE-GRAPHQL-PROXY branch is deployed to platta: https://venue-graphql-proxy-pr920.dev.hel.ninja 🚀🚀🚀

@terovirtanen

Copy link
Copy Markdown
Contributor

EVENTS-GRAPHQL-PROXY branch is deployed to platta: https://events-graphql-proxy-pr920.dev.hel.ninja 🚀🚀🚀

@terovirtanen

Copy link
Copy Markdown
Contributor

HARRASTUKSET-UI branch is deployed to platta: https://harrastukset-pr920.dev.hel.ninja 🚀🚀🚀

@terovirtanen

Copy link
Copy Markdown
Contributor

TAPAHTUMAT-UI branch is deployed to platta: https://tapahtumat-pr920.dev.hel.ninja 🚀🚀🚀

@sonarqubecloud

Copy link
Copy Markdown

@terovirtanen

Copy link
Copy Markdown
Contributor

LIIKUNTA-UI branch is deployed to platta: https://liikunta-pr920.dev.hel.ninja 🚀🚀🚀

@terovirtanen

Copy link
Copy Markdown
Contributor

TestCafe result is failed for https://harrastukset-pr920.dev.hel.ninja 😿💢💥💥

@terovirtanen

Copy link
Copy Markdown
Contributor

TestCafe result is failed for https://tapahtumat-pr920.dev.hel.ninja 😿💢💥💥

@terovirtanen

Copy link
Copy Markdown
Contributor

TestCafe result is failed for https://liikunta-pr920.dev.hel.ninja 😿💢💥💥

@karisal-anders karisal-anders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One refactoring/cleaning that came to mind is that the SCSS files that only forward another SCSS file aren't really necessary anymore. They imports that use them could be changed to use the forwarded files directly. Something to consider, not required for merging.

@nikomakela nikomakela merged commit 054d3ac into main Nov 24, 2025
117 of 123 checks passed
@charn charn deleted the LIIKUNTA-768-fix-style-imports branch July 8, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants