Modernize styling structure and fix component imports #920
Conversation
LIIKUNTA-768
LIIKUNTA-768. Using Turbopack makes it clear that global stylesheets can only be imported in App component. When running app with a Turbopack, a following warning is printed in terminal: ```shell Global CSS cannot be imported from files other than your Custom <App>. Due to the Global nature of stylesheets, and to avoid conflicts, Please move all first-party global CSS imports to pages/_app.js. Or convert the import to Component-Level CSS (CSS Modules). ```
|
|
|
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-hobbies-pr920.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-events-pr920.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-sports-pr920.dev.hel.ninja 🚀🚀🚀 |
|
VENUE-GRAPHQL-PROXY branch is deployed to platta: https://venue-graphql-proxy-pr920.dev.hel.ninja 🚀🚀🚀 |
|
EVENTS-GRAPHQL-PROXY branch is deployed to platta: https://events-graphql-proxy-pr920.dev.hel.ninja 🚀🚀🚀 |
|
HARRASTUKSET-UI branch is deployed to platta: https://harrastukset-pr920.dev.hel.ninja 🚀🚀🚀 |
|
TAPAHTUMAT-UI branch is deployed to platta: https://tapahtumat-pr920.dev.hel.ninja 🚀🚀🚀 |
|
|
LIIKUNTA-UI branch is deployed to platta: https://liikunta-pr920.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is failed for https://harrastukset-pr920.dev.hel.ninja 😿💢💥💥 |
TestCafe result is failed for https://tapahtumat-pr920.dev.hel.ninja 😿💢💥💥 |
TestCafe result is failed for https://liikunta-pr920.dev.hel.ninja 😿💢💥💥 |
karisal-anders
left a comment
There was a problem hiding this comment.
One refactoring/cleaning that came to mind is that the SCSS files that only forward another SCSS file aren't really necessary anymore. They imports that use them could be changed to use the forwarded files directly. Something to consider, not required for merging.



LIIKUNTA-768
Several architectural improvements and necessary fixes related to styling, component imports, and exports.
The changes aim to clean up the codebase, leverage modern SCSS features, and ensure compatibility with build environments like Turbopack.