TH-1428 | Remove experimental x and x_ prefixes from fullText & ongoing#945
Conversation
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-hobbies-pr945.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-events-pr945.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-sports-pr945.dev.hel.ninja 🚀🚀🚀 |
There was a problem hiding this comment.
Looks good!
#807 was the first iteration that just got old, but it looks close enough.
Since LinkedEvents has not published the changes of their end, we cannot test this yet, at all. Also, it's not ideal that they are really going to replace the field, not publish it on side of another. This means that we will have a broken product in our production environment for some time. :(
Sure we could have both fields available in our proxy and supergraph and we could even resolve the non-x-prefixed field to a x-prefixed field. That would get us forward a bit and we wouldn't have so big deployment process when the actual change happens. But I guess this is enough too.
|
VENUE-GRAPHQL-PROXY branch is deployed to platta: https://venue-graphql-proxy-pr945.dev.hel.ninja 🚀🚀🚀 |
|
EVENTS-GRAPHQL-PROXY branch is deployed to platta: https://events-graphql-proxy-pr945.dev.hel.ninja 🚀🚀🚀 |
|
HARRASTUKSET-UI branch is deployed to platta: https://harrastukset-pr945.dev.hel.ninja 🚀🚀🚀 |
|
LIIKUNTA-UI branch is deployed to platta: https://liikunta-pr945.dev.hel.ninja 🚀🚀🚀 |
|
TAPAHTUMAT-UI branch is deployed to platta: https://tapahtumat-pr945.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://liikunta-pr945.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is failed for https://harrastukset-pr945.dev.hel.ninja 😿💢💥💥 |
TestCafe result is failed for https://tapahtumat-pr945.dev.hel.ninja 😿💢💥💥 |
done: - replace `xFullText` with `fullText` - replace `xOngoing` with `ongoing` - replace `x_full_text` with `full_text` - replace `x_ongoing` with `ongoing` - remove mentions of experimental fields as they're not experimental anymore after removing the "x" / "x_" prefixes refs TH-1428
karisal-anders
force-pushed
the
TH-1428-remove-x-prefix
branch
from
750f7ff to
58bb473
Compare
|
Rebased on current main. |
|
|
|
|
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-hobbies-pr945.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-events-pr945.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-sports-pr945.dev.hel.ninja 🚀🚀🚀 |
|
VENUE-GRAPHQL-PROXY branch is deployed to platta: https://venue-graphql-proxy-pr945.dev.hel.ninja 🚀🚀🚀 |
|
EVENTS-GRAPHQL-PROXY branch is deployed to platta: https://events-graphql-proxy-pr945.dev.hel.ninja 🚀🚀🚀 |
|
HARRASTUKSET-UI branch is deployed to platta: https://harrastukset-pr945.dev.hel.ninja 🚀🚀🚀 |
|
LIIKUNTA-UI branch is deployed to platta: https://liikunta-pr945.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://liikunta-pr945.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is failed for https://harrastukset-pr945.dev.hel.ninja 😿💢💥💥 |
|
TAPAHTUMAT-UI branch is deployed to platta: https://tapahtumat-pr945.dev.hel.ninja 🚀🚀🚀 |
|
TestCafe result is failed for https://tapahtumat-pr945.dev.hel.ninja 😿💢💥💥 |
3 participants
Description
Remove experimental
xandx_prefixes from fullText & ongoingdone:
xFullTextwithfullTextxOngoingwithongoingx_full_textwithfull_textx_ongoingwithongoingRelated
TH-1428
Testing
Automated tests
Manual testing
Screenshots
Additional notes