Fix CMS page styles without upgrading HCRC-lib#967
Conversation
LIIKUNTA-771. Fix CMS page's figure table displaying issues by showing the figure as grid. This makes rest of the content to not overflow from it's width limits and the figure table becomes horizontally scrollable in small screens. NOTE: This temporary fix can be removed when HCRC is upgraded to fix this.
LIIKUNTA-771. Fix styles of button links in sidebar. NOTE: This temporary fix can be removed when HCRC is upgraded to fix this.
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-sports-pr967.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-hobbies-pr967.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-events-pr967.dev.hel.ninja 🚀🚀🚀 |
|
EVENTS-GRAPHQL-PROXY branch is deployed to platta: https://events-graphql-proxy-pr967.dev.hel.ninja 🚀🚀🚀 |
|
|
VENUE-GRAPHQL-PROXY branch is deployed to platta: https://venue-graphql-proxy-pr967.dev.hel.ninja 🚀🚀🚀 |
|
LIIKUNTA-UI branch is deployed to platta: https://liikunta-pr967.dev.hel.ninja 🚀🚀🚀 |
|
HARRASTUKSET-UI branch is deployed to platta: https://harrastukset-pr967.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://liikunta-pr967.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://harrastukset-pr967.dev.hel.ninja 😆🎉🎉🎉 |
karisal-anders
left a comment
karisal-anders
left a comment
There was a problem hiding this comment.
Screenshots when running locally this PR's sports app using production data as input:
In the latter screenshot I swiped the table and I could see the table fully using swiping.
Tested only sports app.
|
Now this is waiting for review (or possible rejection in favor of PR #966? Depends) by @City-of-Helsinki/ratkaisutoimiston-backend and/or @City-of-Helsinki/ratkaisutoimiston-frontend |
|
Closing this because #966 is preferred and approved. |
2 participants
LIIKUNTA-771.
To fix CMS page table figure style issues without upgrading HCRC-lib (NOTE: HCRC -lib needs to be upgraded to a organisation scoped version).
Alternative to #966. This is a secondary option and it would be good to upgrade to organisation scoped package.