Skip to content

HAI-3593 Fix comma error in attachement file names#1130

Merged
umeetiusbaar merged 3 commits intodevfrom
HAI-3593/fix-comma-in-attachment-filename
Oct 8, 2025
Merged

HAI-3593 Fix comma error in attachement file names#1130
umeetiusbaar merged 3 commits intodevfrom
HAI-3593/fix-comma-in-attachment-filename

Conversation

@umeetiusbaar
Copy link
Copy Markdown
Contributor

@umeetiusbaar umeetiusbaar commented Oct 7, 2025

Description

Encode attachment file name properly so that commas (or other special characters) work.
Add a startup component to fix existing files in Azure Blob Storage.

Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-3593

Type of change

  • Bug fix
  • New feature
  • Other

Instructions for testing

Testing new attachments:

  1. Create or open a Hanke or an Application
  2. Add attachment with e.g. a comma in the file name
  3. Try to open the attachment in UI
  4. It should work

Testing the fix for existing attachments:

  1. Use dev branch for the backend
  2. Add an attachment with e.g. comma in filename in UI (if you try to open it, it should fail)
  3. Restart the backend with this branch using env variable HAITATON_ATTACHMENT_NAME_FIX_ENABLED=true (default is false)
  4. In startup the files should be fixed in Azure Blob Storage
  5. Try to open the attachment that failed in step 2 in UI - it should work now

Checklist:

  • I have written new tests (if applicable)
  • I have ran the tests myself (if applicable)
  • I have made necessary changes to the documentation, link to confluence
    or other location:

…r special characters) work. Add a startup component to fix existing files in Azure Blob Storage.
…or other special characters) work. Add a startup component to fix existing files in Azure Blob Storage.
…ommas (or other special characters) work. Add a startup component to fix existing files in Azure Blob Storage.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2025

Test Results

  413 files      1 errors  412 suites   2m 52s ⏱️
2 574 tests 2 574 ✅ 0 💤 0 ❌
2 825 runs  2 825 ✅ 0 💤 0 ❌

For more details on these parsing errors, see this check.

Results for commit 7086461.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 8, 2025

@umeetiusbaar umeetiusbaar merged commit e7e0cfe into dev Oct 8, 2025
4 of 5 checks passed
@umeetiusbaar umeetiusbaar deleted the HAI-3593/fix-comma-in-attachment-filename branch October 8, 2025 12:50
umeetiusbaar added a commit that referenced this pull request Oct 9, 2025
* HAI-3593 Encode attachment file name properly so that commas (or other special characters) work. Add a startup component to fix existing files in Azure Blob Storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants