Hds 2624 table of contents should move focus#1502
Merged
mrTuomoK merged 3 commits intodevelopmentfrom Apr 3, 2025
Merged
Conversation
timwessman
force-pushed
the
hds-2624-table-of-contents-should-move-focus
branch
from
311343d to
d5a19d6
Compare
Test Results 1 files 68 suites 17m 39s ⏱️ Results for commit 224be5c. ♻️ This comment has been updated with latest results. |
mrTuomoK
force-pushed
the
hds-2624-table-of-contents-should-move-focus
branch
from
d5a19d6 to
6d5ef4a
Compare
|
Preview found from hds-demo docs/preview_1502 Demos |
Contributor
|
Hmmm... without screenReader I can't see any focus on the headers? Is it correct (maybe it is 🤷 )? With the reader it's highlighted yes. |
timwessman
force-pushed
the
hds-2624-table-of-contents-should-move-focus
branch
from
6d5ef4a to
822c44f
Compare
timwessman
force-pushed
the
hds-2624-table-of-contents-should-move-focus
branch
from
822c44f to
224be5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a user navigates to an anchor link (like form table of contents) focus moves to the linked heading
HDS-2639 (second commit) heading text is inside of an anchor element, so the whole heading is a link
No need to set tabIndex for headings because those are links and are keyboard-navigable
Note: Navigation or Side navigation should not move focus (other than to the beginning of the document)
Related Issue
Closes HDS-2624
Closes HDS-2627
Closes HDS-2639
Motivation and Context
How Has This Been Tested?
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog