HDS-2644: HDS Notification updates (for Helsinki Notification)#1512
HDS-2644: HDS Notification updates (for Helsinki Notification)#1512mrTuomoK merged 9 commits intodevelopmentfrom
Conversation
Test Results 1 files 68 suites 23m 32s ⏱️ Results for commit ceb21c6. ♻️ This comment has been updated with latest results. |
|
Preview found from hds-demo docs/preview_1512 Demos |
mrTuomoK
left a comment
mrTuomoK
left a comment
There was a problem hiding this comment.
Check the comments, at least the table is broken and I think we'd prefer to give the Link as a link-component instead of separate props.
|
Also CHANGELOG changes are missing, no release-please in use in HDS. |
|
BTW does this support giving separate aria-label for the link? (by using the |
|
Also checked this and looks good to me👍 Good job! One thing I noticed on the docsite (not from this PR, it seems to be a published feature😅) Variations/Inline example has different sizes. These would look neater with just the default size: 
|
|
Add a link to Link-component from the table of props |
|
Should we also force the use of medium-size Link despite whatever the user has set? 🤔 |
- link color - do not render invalid links - always render in medium-size
mrTuomoK
left a comment
mrTuomoK
left a comment
There was a problem hiding this comment.
I approve but yeah I have my own commits here so a bit biased.
…44"" This reverts commit 1bc35bd.
…44"" This reverts commit 1bc35bd.
4 participants
Description
Related Issue
Closes HDS-2644
Closes HDS-2645
Closes HDS-2646
Closes HDS-2649
No new changes but verify is implemented as defined:
HDS-2647