KER-601 | show existing comments when commenting is not ongoing#1277
Merged
jorilindell merged 3 commits intomainfrom Apr 13, 2026
Merged
KER-601 | show existing comments when commenting is not ongoing#1277jorilindell merged 3 commits intomainfrom
jorilindell merged 3 commits intomainfrom
Conversation
userEvent.click is asynchronous in @testing-library/user-event v14+, so it must be awaited to ensure interactions are fully processed before assertions run. Refs: KER-601
Render the comment section when comments already exist, even if section.commenting is none. This keeps old comments visible. Refs KER-601
jorilindell
force-pushed
the
KER-601-show-old-comments
branch
from
9faf580 to
9c88eeb
Compare
|
|
KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1277-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://kerrokantasi-pr1277-ui.dev.hel.ninja 😆🎉🎉🎉 |
|
KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1277-ui.dev.hel.ninja 🚀🚀🚀 |
tjgofore
approved these changes
Apr 13, 2026
e2e tests result is success for https://kerrokantasi-pr1277-ui.dev.hel.ninja 😆🎉🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes comment visibility in closed/non-commenting sections.
If a section already has comments, the comment section is now rendered
even when commenting is set to none. This keeps previously added comments
visible instead of hiding them.
Main change
mode being none.
Extra changes in branch
Refs: KER-601