feat(sentry): setup before_send to ignore global id errors by message#461
feat(sentry): setup before_send to ignore global id errors by message#461nikomakela wants to merge 1 commit into
Conversation
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr461.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr461.api.dev.hel.ninja 😆🎉🎉🎉 |
33305b1 to
d4b9074
Compare
|
NOTE: We may not want to have this feature enabled, because then we cannot follow these "unknown" issues in Sentry. |
24b03ca to
a45948b
Compare
d4b9074 to
59b5bb9
Compare
nikomakela
left a comment
There was a problem hiding this comment.
As discussed with @karisal-anders , something like this could be an improvement?
karisal-anders
left a comment
There was a problem hiding this comment.
With the str(exc_value) change (it's clearer that way) looks ok to me, adding a comment about what the "Unable to parse global ID" error is about, and why it is ok to ignore it (i.e. if it is akin to a 404 but thrown by Graphene, and that we have not found a systematic problem with our system creating such problematic non-parseable global ID values) would add clarity/transparency to this still.
a45948b to
e3c4e4c
Compare
6be690a to
72042da
Compare
e3c4e4c to
bc6e627
Compare
KK-1395. The ignore_messages option in sentry_sdk would be great, but since the Graphene raises a general Exception from invalid global ids, we need to follow the exception message instead of class.
72042da to
b4706a0
Compare
|
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr461.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr461.api.dev.hel.ninja 😆🎉🎉🎉 |
|
We looked into this 30.1.2025 and there were still some valid sentry issues related to this, so we should keep following the issue and not merge this PR yet. |
|
Converted to draft, since there is no plan for this yet and Solution office requested the change to draft. |



KK-1395.
The ignore_messages option in sentry_sdk would be great, but since the Graphene raises a general Exception from invalid global ids, we need to follow the exception message instead of class.