(→PR #495) PT-453 | Add cultural route support#494
Closed
karisal-anders wants to merge 2 commits into
Closed
Conversation
Fix "yarn typecheck":
```
$ yarn typecheck
yarn run v1.22.22
$ tsc --project ./tsconfig.json --noEmit
src/domain/headless-cms/components/__tests__/CmsPage.test.tsx:113:11 -
error TS2322: Type '"primary"' is not assignable to type
'ButtonVariant.Primary | ButtonVariant.Secondary | ButtonVariant.Success
| ButtonVariant.Danger | ButtonVariant.Clear | undefined'.
113 loadMoreButtonVariant: 'primary',
~~~~~~~~~~~~~~~~~~~~~
src/domain/headless-cms/components/__tests__/CmsPage.test.tsx:114:11 -
error TS2322: Type '"coat"' is not assignable to type 'ButtonPresetTheme
| ButtonTheme | undefined'.
114 loadMoreButtonTheme: 'coat',
~~~~~~~~~~~~~~~~~~~
src/playwright/tests/search.spec.ts:55:41 - error TS2345: Argument of
type '"Detaljerad sökning"' is not assignable to parameter of type
'SearchButton'.
55 await frontPageSv.clickSearchButton('Detaljerad sökning');
~~~~~~~~~~~~~~~~~~~~
src/playwright/tests/search.spec.ts:71:41 - error TS2345: Argument of
type '"Advanced search"' is not assignable to parameter of type
'SearchButton'.
71 await frontPageEn.clickSearchButton('Advanced search');
~~~~~~~~~~~~~~~~~
```
Refs: PT-453
|
KULTUS-UI branch is deployed to platta: https://kultus-ui-pr494.dev.hel.ninja 🚀🚀🚀 |
karisal-anders
force-pushed
the
PT-453-add-culture-path-support
branch
from
024a2be to
649d161
Compare
|
KULTUS-UI branch is deployed to platta: https://kultus-ui-pr494.dev.hel.ninja 🚀🚀🚀 |
karisal-anders
force-pushed
the
PT-453-add-culture-path-support
branch
2 times, most recently
from
cc4364c to
118ddf9
Compare
|
KULTUS-UI branch is deployed to platta: https://kultus-ui-pr494.dev.hel.ninja 🚀🚀🚀 |
also: - with the request of the product owner don't restore any previous answer to "Is part of cultural route" question from local storage persisted Formik form's data, but instead always reset the question to its initial value i.e. no data given at all - update generated GraphQL types using backend running City-of-Helsinki/palvelutarjotin#509 i.e. the backend support for the `is_part_of_cultural_route` field in enrolments and queue enrolments - add tests - update playwright tests Refs: PT-453
karisal-anders
force-pushed
the
PT-453-add-culture-path-support
branch
from
118ddf9 to
f08c5ab
Compare
|
Contributor
Author
|
Replaced by PR #495 |
karisal-anders
changed the title
|
KULTUS-UI branch is deployed to platta: https://kultus-ui-pr494.dev.hel.ninja 🚀🚀🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced by PR #495