fix(graphql): Optimize N+1 query for occurrences pEvent and languages#505
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(graphql): Optimize N+1 query for occurrences pEvent and languages#505sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
|
KULTUS-API branch is deployed to platta: https://kultus-pr505.api.dev.hel.ninja 🚀🚀🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an N+1 query issue occurring when fetching
PalvelutarjotinEventdata for eachOccurrenceandlanguagesfor eachOccurrencewithin GraphQL queries.Specifically,
OccurrenceNode.get_queryset()inoccurrences/schema.pyhas been updated to includeselect_related("p_event")andprefetch_related("languages"). This ensures that the relatedPalvelutarjotinEventobject andlanguagesare fetched efficiently in a single query (or a minimal number of queries for prefetch_related) when occurrences are retrieved, significantly reducing database load for GraphQL requests to the/graphql/endpoint that include occurrence details.Fixes KULTUS-API-B