fix(graphql): Resolve N+1 query for StudyLevel translations#507
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(graphql): Resolve N+1 query for StudyLevel translations#507sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
|
KULTUS-API branch is deployed to platta: https://kultus-pr507.api.dev.hel.ninja 🚀🚀🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue identified in the GraphQL API when fetching
StudyLevelobjects and their associatedtranslations.Root Cause:
The
StudyLevelNode.get_querysetmethod was not utilizingprefetch_related('translations'), leading to a separate database query for translations for eachStudyLevelinstance returned in the GraphQL response.Changes Made:
prefetch_related('translations')to theStudyLevelNode.get_querysetmethod inoccurrences/schema.py. This ensures that all relatedStudyLevelTranslationobjects are fetched in a single, optimized query, significantly reducing the number of database calls.DjangoObjectTypeclasses inoccurrences/schema.pythat useTranslatableModelto ensure similar N+1 patterns are not present for their translation fields. No other immediate issues were found in this scope.Impact:
This change improves the performance of GraphQL queries involving
StudyLeveltranslations by eliminating redundant database queries.Fixes KULTUS-API-F