Don't disable temporary vehicle immediately when ending permit#567
Merged
Don't disable temporary vehicle immediately when ending permit#567
Conversation
tonipel
force-pushed
the
dont-disable-temporary-vehicle-immediatly
branch
from
7bb65d4 to
f0e49b4
Compare
mhieta
changed the title
mhieta
reviewed
Jan 27, 2025
mhieta
reviewed
Jan 27, 2025
mhieta
reviewed
Jan 27, 2025
mhieta
reviewed
Jan 27, 2025
mhieta
reviewed
Jan 27, 2025
mhieta
requested changes
Jan 27, 2025
tonipel
force-pushed
the
dont-disable-temporary-vehicle-immediatly
branch
from
f0e49b4 to
dd605cf
Compare
|
tonipel
force-pushed
the
dont-disable-temporary-vehicle-immediatly
branch
from
dd605cf to
bbe654e
Compare
when ending permit
tonipel
force-pushed
the
dont-disable-temporary-vehicle-immediatly
branch
from
bbe654e to
4c445d3
Compare
tonipel
force-pushed
the
dont-disable-temporary-vehicle-immediatly
branch
from
e31376a to
7d3b87d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't disable temporary vehicle immediatly when ending permit.
Context
Previously temporary vehicles were disabled immediatly always when used ended their permit.
How Has This Been Tested?
Manually and automated testing.
Manual Testing Instructions for Reviewers
If user has a temporary vehicle and ends their permit, the temporary vehicle is disabled only when the permit ends, or as before if permit has a longer period left than temporary vehicle.
Screenshots