Add hard limit for amount of returned products#569
Merged
Conversation
Sometimes this function could return one product more than month_count, add hard limit so more than month_count products can't be returned.
|
mhieta
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sometimes this function could return one product
more than month_count, add hard limit so more
than month_count products can't be returned.
Context
As far as I know, the bug only occured if permit end date happened to be 29.1.2025.
In such case, if the user would add two or more months to extension request, which
caused extra month to appear.
How Has This Been Tested?
Tested manually.
Manual Testing Instructions for Reviewers
Users should not be able to buy more than 12 months of extension.
Screenshots