useLocaleStorageValue should not do anything server side#216
Merged
Conversation
| }; | ||
|
|
||
| // Utility function to check if we are in a browser environment | ||
| const isBrowser = typeof window !== 'undefined'; |
Contributor
There was a problem hiding this comment.
Suggested change
| const isBrowser = typeof window !== 'undefined'; | |
| const isBrowser = () => typeof window !== 'undefined'; |
and changing the if (!isBrowser) { to if (!isBrowser()) {.
Wouldn't that be safer because the window's value would be evaluated each time the isBrowser function is run, not just once?
Contributor
Author
There was a problem hiding this comment.
Yea, and actually, the second function is void, so it should not return null.
nikomakela
force-pushed
the
LIIKUNTA-764-fix-console-message
branch
from
60e22d6 to
e21e18b
Compare
nikomakela
force-pushed
the
LIIKUNTA-764-fix-console-message
branch
from
e21e18b to
e3a04b6
Compare
karisal-anders
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LIIKUNTA-764.
Upgrade the (patch) version number.