Initialize Sonarcloud for test coverage and code quality reports#218
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
995af90 to
282b260
Compare
|
I expect that we need to transfer the NPM project to some other organisation in order to get the common publish template to work. |
|
I think we should also setup a release please process for this repo. Sure it isn't mandatory to be done in this PR, but it would make this repo more consistent with other. Release please would handle
What do you think @terovirtanen and @karisal-anders ? |
| sonar.sourceEncoding=UTF-8 | ||
|
|
||
| # Paths to exclude from analysis | ||
| sonar.exclusions=**/node_modules/**,**/dist/**,**/lib/**,**/coverage/**,**/.storybook/**,**/scripts/**,**/*.js,**/*.d.ts |
There was a problem hiding this comment.
.js files could be included, there aren't many of them
|
|
||
| # Paths to test files | ||
| sonar.tests=src | ||
| sonar.test.inclusions=src/**/*.test.ts,src/**/*.test.tsx,src/**/__tests__/**/*.{ts,tsx},src/tests/**/*.{ts,tsx} |
There was a problem hiding this comment.
The src/tests doesn't seem to be a test directory, it only has apolloConfig.tsx and hideConsoleMessages.tsx. Maybe the directory could be renamed to something else to make it clearer as to what it is. Because of this src/tests doesn't seem to be useful to include here.
karisal-anders
left a comment
There was a problem hiding this comment.
Left some comments. Please take a look at them.
I'm slightly eager to get the SonarCloud coverage & reporting into |
I agree. release-please example can be found from https://github.com/City-of-Helsinki/react-helsinki-notification-manager/blob/0fcf09a90576c7669b0edfe08c36429f6a506772/.github/workflows/release-please.yml |
|
I can merge this so we get the sonar cloud running, as @karisal-anders suggested. I'll start to setup release-please next @terovirtanen . |
HCRC-186.
HCRC-186. Modify the existing CI workflow configurations so that they use the city of Helsinki common workflows available in github.com/City-of-Helsinki/.github/blob/main/.github/workflows/.
282b260 to
17186b7
Compare
|




HCRC-186.