ci: use common workflow to release canary on main branch push#225
Merged
Conversation
karisal-anders
approved these changes
Dec 10, 2025
Contributor
Author
|
A Github action can be set as a trusted publisher in NPM. However, it looks like the NPM allows only 1 trusted publisher (meaning 1 Github workflow) and with this setup that we have in this PR, we have 2 different workflows. We have 1 for canary releases and 1 for stable releases via release-please. We need to refactor this a bit. |
HCRC-189. 1. Use common workflow to release canary on mainbranch push. 2. Merge npm-publish-canary workflow to release-please. The common Github workflows are using NPM's trusted publisher feature. A Github workflow / action can be set as a trusted publisher, but the NPM supports only 1 workflow. We have had 2: npm-canary-release and npm-stable-release. After refactoring, the stable releases are done with a release-please action, but we need to support releasing canary-releases in the same workflow file, in order to publish both types as a trusted publisher.
5607e4d to
b21882f
Compare
|
Contributor
Author
|
Merged npm-publish-canary.yml content to release-please.yml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



HCRC-189.
Depends on City-of-Helsinki/.github#22.