Skip to content

ci: use common workflow to release canary on main branch push#225

Merged
nikomakela merged 1 commit into
mainfrom
HCRC-189-canary-release
Dec 12, 2025
Merged

ci: use common workflow to release canary on main branch push#225
nikomakela merged 1 commit into
mainfrom
HCRC-189-canary-release

Conversation

@nikomakela

Copy link
Copy Markdown
Contributor

HCRC-189.

Depends on City-of-Helsinki/.github#22.

@terovirtanen terovirtanen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikomakela

Copy link
Copy Markdown
Contributor Author

A Github action can be set as a trusted publisher in NPM. However, it looks like the NPM allows only 1 trusted publisher (meaning 1 Github workflow) and with this setup that we have in this PR, we have 2 different workflows. We have 1 for canary releases and 1 for stable releases via release-please.

We need to refactor this a bit.

HCRC-189.

1. Use common workflow to release canary on mainbranch push.
2. Merge npm-publish-canary workflow to release-please.

The common Github workflows are using NPM's trusted publisher feature. A
Github workflow / action can be set as a trusted publisher, but the NPM
supports only 1 workflow. We have had 2: npm-canary-release and
npm-stable-release. After refactoring, the stable releases are done with
a release-please action, but we need to support releasing
canary-releases in the same workflow file, in order to publish both
types as a trusted publisher.
@nikomakela nikomakela force-pushed the HCRC-189-canary-release branch from 5607e4d to b21882f Compare December 12, 2025 14:05
@sonarqubecloud

Copy link
Copy Markdown

@nikomakela

Copy link
Copy Markdown
Contributor Author

Merged npm-publish-canary.yml content to release-please.yml.

@nikomakela nikomakela merged commit 674ee95 into main Dec 12, 2025
5 checks passed
@nikomakela nikomakela deleted the HCRC-189-canary-release branch December 12, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants