HCRC-175 | Require node v22 LTS & fix Docker#227
Merged
Conversation
In addition to added security this also speeds up "docker compose up --build" as less of the unnecessary context is copied to the container. refs HCRC-175
fixes "docker compose up --build" which previously failed with: ``` error hds-design-tokens@4.8.1: The engine "node" is incompatible with this module. Expected version "^22.13.1". Got "20.19.5" ``` node v22.11.0 is LTS: - https://nodesource.com/blog/Node.js-v22-Long-Term-Support-LTS refs HCRC-175
|
karisal-anders
changed the title
nikomakela
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Done:
.dockerignorefor security & speedRelated
Testing
Automated tests
Manual testing
Tested locally that
docker compose up --buildnow worked, and I could open storybook that's run in containerScreenshots
Additional notes