RATY-357 stuck Dependabot workflows#1378
Open
mikkojamG wants to merge 13 commits into
Open
Conversation
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR migrates ESLint to a flat config, updates lint-related package and workspace settings, and removes legacy lint suppressions. It also includes several small component, view, redux, utility, and server code adjustments tied to the linting update. ChangesESLint Migration and Codebase Cleanup
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
eslint.config.mjs (1)
28-30: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winHardcoded React version will drift from the actual dependency.
react: { version: '19.0.0' }is hardcoded, butsrc/testUtils.js's library context indicates the installed React version is already19.2.7.eslint-plugin-reactsupports"version": "detect"to auto-detect the installed version, avoiding staleness as React gets bumped.♻️ Proposed fix
settings: { - react: { version: '19.0.0' }, + react: { version: 'detect' }, },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@eslint.config.mjs` around lines 28 - 30, The React version in the ESLint settings is hardcoded and can drift from the installed dependency. Update the react setting in eslint.config.mjs to use version detection instead of a fixed string, so eslint-plugin-react stays aligned automatically as React changes. Use the existing settings block near the react configuration to replace the literal version with the plugin’s auto-detect option.src/views/MapView/components/TransitStops/TransitStopInfo/TransitStopInfo.js (1)
146-155: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winUse a stable trip identifier for this departure key.
shortName-serviceDay-realtimeDeparturecan still collide when two same-route departures share the same second, which causes React key warnings and unstable reconciliation. If a unique trip id is available from the API, add it to the query and use that here instead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/views/MapView/components/TransitStops/TransitStopInfo/TransitStopInfo.js` around lines 146 - 155, The departure key in TransitStopInfo should not rely on route shortName plus serviceDay and realtimeDeparture because it can still collide for same-route departures. Update the departure data query in TransitStopInfo and the mapping logic that builds each DepartureItemContainer key to use a stable unique trip identifier from the API when available, keeping the existing route/time fields only as fallback if needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@eslint.config.mjs`:
- Around line 63-82: The server config block currently only sets parser/globals
for server/**/*.js and leaves those files without any lint rules, so they are
effectively unlinted. Update the eslint.config.mjs flat config so the server
block for server/**/*.js also inherits the shared rule set (or otherwise defines
the intended plugins/rules) used by the src/**/*.{js,jsx} config, while keeping
the Node globals and build-time constants. Use the existing config objects in
eslint.config.mjs to ensure server files are actually linted when running the
lint script.
- Around line 38-41: The react-hooks config is being read from the wrong preset
path in eslint.config.mjs. Update the spread on reactHooksPlugin to use the flat
config namespace for the recommended-latest preset, matching how the other flat
configs are referenced, and keep the surrounding rules block unchanged.
In `@package.json`:
- Around line 108-123: The dependency list in package.json still pins
eslint-plugin-react and eslint-plugin-react-hooks to versions that only support
ESLint 9, which conflicts with the ESLint 10 upgrade. Update the package.json
entries for eslint-plugin-react and eslint-plugin-react-hooks to ESLint
10-compatible releases, and keep the rest of the linting toolchain aligned so
installation does not produce peer-dependency warnings or errors.
In `@src/routes/index.js`:
- Around line 299-308: The Division route is still using the old Route render
prop, which is ignored in react-router-dom v6 and prevents
/division/:city?/:area? from rendering. Update the Route in the index routes
setup to use the v6 element prop instead, and move the PageHandler,
DivisionView, and HomeView composition into the element value so the route
matches and renders correctly.
---
Nitpick comments:
In `@eslint.config.mjs`:
- Around line 28-30: The React version in the ESLint settings is hardcoded and
can drift from the installed dependency. Update the react setting in
eslint.config.mjs to use version detection instead of a fixed string, so
eslint-plugin-react stays aligned automatically as React changes. Use the
existing settings block near the react configuration to replace the literal
version with the plugin’s auto-detect option.
In
`@src/views/MapView/components/TransitStops/TransitStopInfo/TransitStopInfo.js`:
- Around line 146-155: The departure key in TransitStopInfo should not rely on
route shortName plus serviceDay and realtimeDeparture because it can still
collide for same-route departures. Update the departure data query in
TransitStopInfo and the mapping logic that builds each DepartureItemContainer
key to use a stable unique trip identifier from the API when available, keeping
the existing route/time fields only as fallback if needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 02c247e1-94a5-42b3-b634-4180d3916a22
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (91)
.eslintrc.jsoneslint.config.mjspackage.jsonpnpm-workspace.yamlserver/.eslintrcsrc/App.jssrc/components/BoldedText/BoldedText.jssrc/components/CloseButton/CloseButton.jssrc/components/DataFetchers/helpers.jssrc/components/DesktopComponent/DesktopComponent.jssrc/components/Dialog/LinkSettingsDialog/LinkSettingsDialogComponent.jssrc/components/Dialog/LinkSettingsDialog/index.jssrc/components/ErrorBoundary/ErrorBoundary.jssrc/components/ListItems/EventItem/EventItem.jssrc/components/ListItems/ResultItem/ResultItem.jssrc/components/ListItems/UnitItem/UnitItem.jssrc/components/Lists/PaginatedList/PaginatedList.jssrc/components/Lists/ResultList/ResultList.jssrc/components/Matomo/MatomoTracker.jssrc/components/Matomo/__tests__/MatomoTracker.test.jssrc/components/Matomo/constants.jssrc/components/Matomo/hooks/__tests__/useMatomo.test.jssrc/components/Matomo/matomo-context.jssrc/components/MobileComponent/MobileComponent.jssrc/components/Navigator/Navigator.jssrc/components/PaginationComponent/PaginationComponent.jssrc/components/ReadSpeakerButton/ReadSpeakerButton.jssrc/components/ResultOrderer/ResultOrderer.jssrc/components/SearchBar/components/SuggestionBox/SuggestionBox.jssrc/components/SettingsComponent/SettingsComponent.jssrc/components/SettingsDropdowns/SettingsDropdowns.jssrc/components/TabLists/TabLists.jssrc/i18n/en.jssrc/i18n/fi.jssrc/i18n/sv.jssrc/layouts/DefaultLayout.jssrc/layouts/components/PageHandler/pageDescriptions.jssrc/layouts/components/ViewTitle/ViewTitle.jssrc/redux/actions/breadcrumb.jssrc/redux/actions/search.jssrc/redux/actions/selectedUnitReservations.jssrc/redux/actions/services.jssrc/redux/selectors/statisticalDistrict.jssrc/routes/index.jssrc/serviceWorker.jssrc/setupTests.jssrc/testUtils.jssrc/utils/address.jssrc/utils/fetch/fetch.jssrc/utils/index.jssrc/utils/localStorage.jssrc/utils/mapUtility.jssrc/utils/newFetch/HTTPClient.jssrc/utils/orderUnits.jssrc/utils/tracking.jssrc/utils/unitHelper.jssrc/utils/units.jssrc/views/AddressView/AddressView.jssrc/views/AddressView/utils/fetchAdministrativeDistricts.jssrc/views/AreaView/AreaView.jssrc/views/AreaView/components/ParkingAreaList/ParkingAreaList.jssrc/views/AreaView/components/SideBar/SideBar.jssrc/views/AreaView/components/StatisticalDistrictList/StatisticalDistrictListComponent.jssrc/views/EmbedderView/components/IFramePreview.jssrc/views/EmbedderView/utils/url.jssrc/views/EventDetailView/EventDetailView.jssrc/views/FeedbackView/FeedbackView.jssrc/views/InfoView/InfoView.jssrc/views/MapView/MapView.jssrc/views/MapView/components/AddressMarker/AddressMarker.jssrc/views/MapView/components/AddressPopup/AddressPopup.jssrc/views/MapView/components/Districts/ParkingAreas.jssrc/views/MapView/components/ElevationControl/ElevationControl.jssrc/views/MapView/components/MarkerCluster/MarkerCluster.jssrc/views/MapView/components/TransitStops/TransitStopInfo/TransitStopInfo.jssrc/views/MapView/components/TransitStops/TransitStops.jssrc/views/MapView/components/UnitGeometry/UnitGeometry.jssrc/views/MapView/components/UserMarker/UserMarker.jssrc/views/MapView/config/mapConfig.jssrc/views/MapView/utils/createMap.jssrc/views/MapView/utils/drawIcon.jssrc/views/MapView/utils/mapActions.jssrc/views/MapView/utils/swapCoordinates.jssrc/views/MapView/utils/transitFetch.jssrc/views/PrintView/PrintView.jssrc/views/SearchView/SearchView.jssrc/views/ServiceTreeView/ServiceTreeView.jssrc/views/ServiceView/ServiceView.jssrc/views/UnitView/UnitView.jssrc/views/UnitView/components/ContactInfo/ContactInfo.jssrc/views/UnitView/components/ExtendedData/ExtendedData.js
💤 Files with no reviewable changes (45)
- src/components/DataFetchers/helpers.js
- src/utils/units.js
- src/components/ListItems/EventItem/EventItem.js
- src/components/Matomo/matomo-context.js
- src/components/Matomo/constants.js
- src/layouts/components/PageHandler/pageDescriptions.js
- src/views/AddressView/utils/fetchAdministrativeDistricts.js
- src/components/ListItems/UnitItem/UnitItem.js
- src/views/InfoView/InfoView.js
- src/views/UnitView/components/ContactInfo/ContactInfo.js
- src/views/AreaView/AreaView.js
- src/components/SettingsDropdowns/SettingsDropdowns.js
- .eslintrc.json
- src/components/Lists/ResultList/ResultList.js
- src/views/MapView/components/AddressMarker/AddressMarker.js
- src/utils/tracking.js
- src/i18n/sv.js
- src/components/PaginationComponent/PaginationComponent.js
- src/views/ServiceTreeView/ServiceTreeView.js
- src/views/MapView/components/TransitStops/TransitStops.js
- src/components/Matomo/hooks/tests/useMatomo.test.js
- src/views/ServiceView/ServiceView.js
- src/views/MapView/MapView.js
- src/components/CloseButton/CloseButton.js
- src/components/Navigator/Navigator.js
- src/components/BoldedText/BoldedText.js
- src/utils/address.js
- src/views/UnitView/UnitView.js
- src/App.js
- src/views/MapView/utils/mapActions.js
- server/.eslintrc
- src/i18n/fi.js
- src/views/MapView/utils/createMap.js
- src/utils/orderUnits.js
- src/views/EventDetailView/EventDetailView.js
- src/views/MapView/utils/swapCoordinates.js
- src/i18n/en.js
- src/components/Matomo/MatomoTracker.js
- src/views/AreaView/components/SideBar/SideBar.js
- src/views/AddressView/AddressView.js
- src/views/MapView/config/mapConfig.js
- src/components/ListItems/ResultItem/ResultItem.js
- src/views/MapView/components/UserMarker/UserMarker.js
- src/components/Matomo/tests/MatomoTracker.test.js
- src/components/ResultOrderer/ResultOrderer.js
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
mikkojamG
force-pushed
the
fix/RATY-357-stuck-dependabot-workflows
branch
from
622a2d0 to
d9b3deb
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves multiple dependencies that are currently breaking Dependabot update workflows.
Summary by CodeRabbit