Skip to content

Use common uwsgi config, update Dockerfile, address Sonarcloud issues#58

Merged
danipran merged 5 commits into
mainfrom
RATYK-199/sonarcloud-issues
May 6, 2026
Merged

Use common uwsgi config, update Dockerfile, address Sonarcloud issues#58
danipran merged 5 commits into
mainfrom
RATYK-199/sonarcloud-issues

Conversation

@danipran

@danipran danipran commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Use common uwsgi config
  • Update Dockerfile to match Dockerfiles in other projects
  • Pass only SONAR_TOKEN to common workflow
  • Add uwsgi service in compose.yaml, for running an uwsgi environment locally
  • Wrap variables in double quotes
  • Move test_settings.py under tests
  • Explicitly tell pip to expect hashes and to not install any other dependencies than the ones listed in requirements files
  • Require binary only on pip/setuptools/wheel upgrade

Refs: RATYK-199

@danipran danipran force-pushed the RATYK-199/sonarcloud-issues branch from ac3d035 to 28232f2 Compare April 30, 2026 11:48
danipran added 4 commits April 30, 2026 14:59
@danipran
feat: update Dockerfile, use common uwsgi config
ce3a9e5 
- Make Dockerfile more in line with other projects' Dockerfiles
- Use City of Helsinki common uwsgi configurations
- Require hashes in pip install
- Do not install dependencies of dependencies

Refs: RATYK-199
@danipran
ci: pass only sonar token to common workflow
5c3c429 
Refs: RATYK-199
@danipran
chore: add uwsgi service in compose.yaml
4976643 
For running a production-like environment locally.

Refs: RATYK-199
@danipran
test: move test_settings under tests
e9d7215 
To make it even more explicit that yes, these are test settings.

Refs: RATYK-199
@danipran danipran force-pushed the RATYK-199/sonarcloud-issues branch from 28232f2 to e9d7215 Compare April 30, 2026 11:59
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 30, 2026
View reviewed changes
Comment thread .docker/Dockerfile Fixed
Comment thread .docker/Dockerfile Fixed
Comment thread .docker/Dockerfile Fixed
@danipran danipran changed the title Ratyk 199/sonarcloud issues Use common uwsgi, update Dockerfile, address Sonarcloud issues Apr 30, 2026
@danipran danipran marked this pull request as ready for review April 30, 2026 12:09
@danipran danipran requested a review from a team as a code owner April 30, 2026 12:09
sentry[bot]
sentry Bot reviewed Apr 30, 2026
View reviewed changes
Comment thread .docker/Dockerfile
@sonarqubecloud

sonarqubecloud Bot commented Apr 30, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@danipran danipran changed the title Use common uwsgi, update Dockerfile, address Sonarcloud issues Use common uwsgi config, update Dockerfile, address Sonarcloud issues Apr 30, 2026
@danipran danipran merged commit 527cd6c into main May 6, 2026
28 checks passed
@danipran danipran deleted the RATYK-199/sonarcloud-issues branch May 6, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments
@voneiden voneiden voneiden approved these changes
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danipran @voneiden @github-advanced-security