chore(main): release tirehtoori 0.3.0#60
Conversation
|
|
||
| ### Features | ||
|
|
||
| * Update Dockerfile, use common uwsgi config ([2127307](https://github.com/City-of-Helsinki/tirehtoori/commit/2127307cae1c5993fe60da7e6ea0f85404fbb89b)) |
There was a problem hiding this comment.
Bug: The uwsgi.ini file uses inline comments which are not supported by the uWSGI parser. With strict = true set, this will cause startup to fail.
Severity: CRITICAL
Suggested Fix
In the .docker/uwsgi.ini file, move all inline comments to their own separate lines above the configuration option they are describing. Comments in INI files must start on a new line with a # or ;.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: CHANGELOG.md#L8
Potential issue: The `.docker/uwsgi.ini` configuration file uses inline comments after
numeric values for options like `max-requests` and `reload-on-rss`. The uWSGI INI parser
does not support inline comments and will interpret the entire line, including the
comment, as the value. This results in a non-integer value for a numeric option. Because
`strict = true` is also set, this parsing error will cause uWSGI to fail to start,
leading to a service outage.
Did we get this right? 👍 / 👎 to inform future reviews.
e40530e to
c8fef7e
Compare
b37a95a to
312f63a
Compare
688ec89 to
9a3f02e
Compare
cd42d46 to
ea5bc26
Compare
3db749f to
08a19be
Compare
3a0686e to
21cd3f9
Compare
2f2d0b4 to
7b19db2
Compare
|
|
||
| ### Features | ||
|
|
||
| * Update Dockerfile, use common uwsgi config ([2127307](https://github.com/City-of-Helsinki/tirehtoori/commit/2127307cae1c5993fe60da7e6ea0f85404fbb89b)) |
There was a problem hiding this comment.
Bug: The container starts as a non-root user default, but the uwsgi.ini configuration tries to switch to user nobody, which will fail and prevent the application from starting.
Severity: CRITICAL
Suggested Fix
Remove the uid = nobody and gid = nogroup lines from .docker/uwsgi.ini. The container is already running as a non-root user (default) as defined in the Dockerfile, so this redundant and incorrect user-switching attempt is not needed.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: CHANGELOG.md#L8
Potential issue: The production Docker container is configured to run as the non-root
user `default`. However, the `uwsgi.ini` configuration attempts to switch the process to
the `nobody` user by setting `uid = nobody`. A non-root process cannot change its user
ID. As a result, when the entrypoint script executes `uwsgi`, the `setuid()` call will
fail due to insufficient privileges. This will cause the uWSGI process to exit with an
error, preventing the application container from starting successfully in the production
environment.
Also affects:
.docker/Dockerfile:77.docker/uwsgi.ini:12.docker/docker-entrypoint.sh:26
06db05c to
a7ecfc2
Compare
6679397 to
c3332e6
Compare
🤖 I have created a release beep boop
0.3.0 (2026-07-12)
Features
Dependencies
This PR was generated with Release Please. See documentation.