Skip to content

chore(main): release tirehtoori 0.3.0#60

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
release-please--branches--main--components--tirehtoori
Open

chore(main): release tirehtoori 0.3.0#60
github-actions[bot] wants to merge 1 commit into
mainfrom
release-please--branches--main--components--tirehtoori

Conversation

@github-actions

@github-actions github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🤖 I have created a release beep boop

0.3.0 (2026-07-12)

Features

  • Update Dockerfile, use common uwsgi config (2127307)

Dependencies

  • Bump django from 5.2.13 to 5.2.14 (4c1014a)
  • Bump pip from 26.0 to 26.1 (66f40fd)
  • Bump urllib3 from 2.6.3 to 2.7.0 (b902d19)

This PR was generated with Release Please. See documentation.

@github-actions github-actions Bot requested a review from a team as a code owner May 6, 2026 09:44
Comment thread CHANGELOG.md

### Features

* Update Dockerfile, use common uwsgi config ([2127307](https://github.com/City-of-Helsinki/tirehtoori/commit/2127307cae1c5993fe60da7e6ea0f85404fbb89b))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The uwsgi.ini file uses inline comments which are not supported by the uWSGI parser. With strict = true set, this will cause startup to fail.
Severity: CRITICAL

Suggested Fix

In the .docker/uwsgi.ini file, move all inline comments to their own separate lines above the configuration option they are describing. Comments in INI files must start on a new line with a # or ;.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: CHANGELOG.md#L8

Potential issue: The `.docker/uwsgi.ini` configuration file uses inline comments after
numeric values for options like `max-requests` and `reload-on-rss`. The uWSGI INI parser
does not support inline comments and will interpret the entire line, including the
comment, as the value. This results in a non-integer value for a numeric option. Because
`strict = true` is also set, this parsing error will cause uWSGI to fail to start,
leading to a service outage.

Did we get this right? 👍 / 👎 to inform future reviews.

@github-actions github-actions Bot force-pushed the release-please--branches--main--components--tirehtoori branch 10 times, most recently from e40530e to c8fef7e Compare May 13, 2026 14:17
@github-actions github-actions Bot force-pushed the release-please--branches--main--components--tirehtoori branch 6 times, most recently from b37a95a to 312f63a Compare May 19, 2026 00:51
@github-actions github-actions Bot force-pushed the release-please--branches--main--components--tirehtoori branch 8 times, most recently from 688ec89 to 9a3f02e Compare May 27, 2026 00:52
@github-actions github-actions Bot force-pushed the release-please--branches--main--components--tirehtoori branch 2 times, most recently from cd42d46 to ea5bc26 Compare May 29, 2026 00:55
@github-actions github-actions Bot force-pushed the release-please--branches--main--components--tirehtoori branch 4 times, most recently from 3db749f to 08a19be Compare June 17, 2026 01:00
Comment thread CHANGELOG.md
@github-actions github-actions Bot force-pushed the release-please--branches--main--components--tirehtoori branch 8 times, most recently from 3a0686e to 21cd3f9 Compare June 25, 2026 00:53
@github-actions github-actions Bot force-pushed the release-please--branches--main--components--tirehtoori branch 5 times, most recently from 2f2d0b4 to 7b19db2 Compare June 30, 2026 00:52
Comment thread CHANGELOG.md

### Features

* Update Dockerfile, use common uwsgi config ([2127307](https://github.com/City-of-Helsinki/tirehtoori/commit/2127307cae1c5993fe60da7e6ea0f85404fbb89b))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The container starts as a non-root user default, but the uwsgi.ini configuration tries to switch to user nobody, which will fail and prevent the application from starting.
Severity: CRITICAL

Suggested Fix

Remove the uid = nobody and gid = nogroup lines from .docker/uwsgi.ini. The container is already running as a non-root user (default) as defined in the Dockerfile, so this redundant and incorrect user-switching attempt is not needed.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: CHANGELOG.md#L8

Potential issue: The production Docker container is configured to run as the non-root
user `default`. However, the `uwsgi.ini` configuration attempts to switch the process to
the `nobody` user by setting `uid = nobody`. A non-root process cannot change its user
ID. As a result, when the entrypoint script executes `uwsgi`, the `setuid()` call will
fail due to insufficient privileges. This will cause the uWSGI process to exit with an
error, preventing the application container from starting successfully in the production
environment.

Also affects:

  • .docker/Dockerfile:77
  • .docker/uwsgi.ini:12
  • .docker/docker-entrypoint.sh:26

@github-actions github-actions Bot force-pushed the release-please--branches--main--components--tirehtoori branch 7 times, most recently from 06db05c to a7ecfc2 Compare July 7, 2026 02:48
@github-actions github-actions Bot force-pushed the release-please--branches--main--components--tirehtoori branch 3 times, most recently from 6679397 to c3332e6 Compare July 10, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant