4.4 Backport Add config setting to disable mandatory tokens check in mai...#34
Open
eileenmcnaughton wants to merge 1 commit intoCiviCRM42:4.2from
Open
4.4 Backport Add config setting to disable mandatory tokens check in mai...#34eileenmcnaughton wants to merge 1 commit intoCiviCRM42:4.2from
eileenmcnaughton wants to merge 1 commit intoCiviCRM42:4.2from
Conversation
…mailings As per a previous discussion (with Lobo IIRC), add a configuration setting to disable the check for presence of mandatory tokens when sending mailings. This setting is implemented as a negative option, i.e. ticking the option disables the check. We could also reverse the logic, so that ticking the option enables the check instead; and set it to on by default... Not sure which is preferable -- I guess that's mostly a matter of taste. Conflicts: CRM/Admin/Form/Preferences/Mailing.php settings/Mailing.setting.php Conflicts: packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...lings
As per a previous discussion (with Lobo IIRC), add a configuration
setting to disable the check for presence of mandatory tokens when
sending mailings.
This setting is implemented as a negative option, i.e. ticking the
option disables the check. We could also reverse the logic, so that
ticking the option enables the check instead; and set it to on by
default... Not sure which is preferable -- I guess that's mostly a
matter of taste.
Conflicts:
Conflicts: