Two updates to tc_build/tools.py#322
Merged
msfjarvis merged 2 commits intoClangBuiltLinux:mainfrom Feb 27, 2026
Merged
Conversation
There are two minor problems with find_host_cc() when using a multicall binary setup. The first is calling .resolve() on a multicall binary, which breaks the multicall setup because the symlink is how the multicall binary works in the first place. Avoid calling .resolve() in the case of multicall binaries. The second is clang-<ver> is not present in a multicall setup, so a versioned binary from elsewhere in PATH can be chosen before a multicall binary because plain clang is checked after the versioned binaries. Check if the first clang in PATH is a multicall binary and use it if so. Otherwise, fallback to looking at versioned binaries first then the unversioned clang so that newer versions of clang, such as those from apt.llvm.org, are chosen first. While in the area, use an else branch for the for loop that looks for compilers, saving a couple lines and a cc check. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
msfjarvis
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
tc_build/tools.pyfor multicall setups and update the LLVM tip of tree version used when a call to GitHub fails.