Skip to content

Patel-Teja: use correlation first#525

Merged
longemen3000 merged 5 commits intomasterfrom
PatelTeja-Exp
Dec 31, 2025
Merged

Patel-Teja: use correlation first#525
longemen3000 merged 5 commits intomasterfrom
PatelTeja-Exp

Conversation

@longemen3000
Copy link
Member

@longemen3000 longemen3000 commented Dec 30, 2025

Before, we used the experimental critical volumes first, then the correlation if no critical volume is available. the original paper does clarify that the critical compressibility factors are fitted, so we should consider that and do not directly query Vc.

It renames the Vc field of PatelTejaParam to Vc_fit and adds the acentricfactor field.

should fix #524

@longemen3000 longemen3000 requested a review from pw0908 December 30, 2025 21:06
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.59%. Comparing base (1cc56ba) to head (e510050).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/models/cubic/PatelTeja/PatelTeja.jl 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   61.66%   61.59%   -0.08%     
==========================================
  Files         368      366       -2     
  Lines       32373    32276      -97     
==========================================
- Hits        19963    19880      -83     
+ Misses      12410    12396      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@longemen3000 longemen3000 merged commit 3ec8e42 into master Dec 31, 2025
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Densities for PatelTeja issues

2 participants