Patel-Teja: use correlation first#525
Merged
longemen3000 merged 5 commits intomasterfrom Dec 31, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #525 +/- ##
==========================================
- Coverage 61.66% 61.59% -0.08%
==========================================
Files 368 366 -2
Lines 32373 32276 -97
==========================================
- Hits 19963 19880 -83
+ Misses 12410 12396 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pw0908
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we used the experimental critical volumes first, then the correlation if no critical volume is available. the original paper does clarify that the critical compressibility factors are fitted, so we should consider that and do not directly query Vc.
It renames the
Vcfield ofPatelTejaParamtoVc_fitand adds theacentricfactorfield.should fix #524