Fix Japanese IME keys on physical keyboards - #584
Open
ah-kun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Japanese IME keys when using a physical Japanese JIS keyboard
with the non-root Android client.
This adds support for:
Problem
When a Japanese JIS keyboard was connected to an Android device,
normal keys and modifiers were forwarded correctly, but the
Hankaku/Zenkaku key did not affect the IME on the Windows host.
KEYCODE_ZENKAKU_HANKAKUand LinuxKEY_ZENKAKUHANKAKUwere notfully mapped in the Android keyboard translation path.
In addition, Japanese IME keys could be marked as normalized.
Apollo then used its US VK-to-scan-code table, where
VK_OEM_AUTO(
0xF3) maps to scan code0x5Finstead of the Japanese keyboardscan code
0x29.Changes
KEYCODE_ZENKAKU_HANKAKUtoVK_OEM_AUTO(0xF3)KEYCODE_HENKANtoVK_CONVERTKEYCODE_MUHENKANtoVK_NONCONVERTKEYCODE_KATAKANA_HIRAGANAtoVK_OEM_COPYcan perform the correct VK-to-scan-code conversion
Testing
Tested with:
Verified:
Commands: