Add optional AC-3 and E-AC-3 5.1 output - #592
Open
BuffMcBigHuge wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Some Android TV and HDMI setups only deliver stereo or silence from multichannel PCM. Encoded Dolby output gives receivers another compatible 5.1 transport. Related to #22 and #283.
Testing
:app:assembleNonRoot_gameDebugpassed forarmeabi-v7a,arm64-v8a,x86, andx86_64.:app:assembleNonRoot_gameRelease -x :app:lintVitalNonRoot_gameReleasepassed for all four ABIs. The skipped gate contains 12 pre-existingvalues-ruextra-translation errors.git diff --checkpassed.ff_ac3_fixed_encoderandff_eac3_encoderpresent.Notes
PCM remains the default, and every encoded option is marked experimental. AC-3 was stable in target testing. E-AC-3 produced 5.1 output, but the target setup previously showed brief intermittent dips. No dip-time trace was captured, so this PR does not include a speculative buffering change.