Skip to content

Qaoa#1345

Merged
roie-d-classiq merged 6 commits intomainfrom
qaoa
Dec 29, 2025
Merged

Qaoa#1345
roie-d-classiq merged 6 commits intomainfrom
qaoa

Conversation

@roie-d-classiq
Copy link
Collaborator

@roie-d-classiq roie-d-classiq commented Dec 10, 2025 •
edited
Loading

PR Description

Some notes

  • Please make sure that the notebook runs successfully with the latest Classiq version.

  • Please make sure that you placed the files in an appropriate folder

    • And that the file names are clear, descriptive, and match the notebook content.
      • Note that we require the file names of .ipynb and .qmod to be unique across this repository.
    • Plus, please make sure that all required files are included: .qmod, .synthesis_options.json, .metadata.json
    • And that images are embedded inside the notebook, not added as external files

  • If applicable, please include link to the paper on which the notebook is based, in the notebook itself.

  • Please use rebase on your branch (no merge commits)

  • Please link this PR to the relevant issue

  • Please make sure to run pre-commit when commiting changes

    • If you're using git in the terminal, make sure to install pre-commit via running pip install pre-commit followed by pre-commit install
    • Note that Classiq runs automatic code linting. Meaning that one of the tests verifies the output of pre-commit.
    • Also note that pre-commit may minorly alter some files. Make sure to git add the changes done by pre-commit

@review-notebook-app
Copy link

review-notebook-app bot commented Dec 10, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Dec 10, 2025 •
edited
Loading

🔥 New notebook just dropped!

@amir-naveh , @TomerGoldfriend — come check out this shiny new addition to our repo.

TomerGoldfriend
TomerGoldfriend reviewed Dec 17, 2025
View reviewed changes
algorithms/qaoa/qaoa.ipynb
@@ -0,0 +1,1155 @@
{
Copy link
Member

@TomerGoldfriend TomerGoldfriend Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo in the name of the last author.

I find the input/output definitions a bit confusing. Indeed everything can eventually be described on bit strings and clauses. However, at the end of the day we usually describe things in higher level.

How about something like

Input: A classical objective function C(x) over a fixed point variable x.

Output: A solution x* ....


Reply via ReviewNB

Copy link
Collaborator Author

@roie-d-classiq roie-d-classiq Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

modified a bit:), I kind of like it that things are defined exactly.

algorithms/qaoa/qaoa.ipynb
@@ -0,0 +1,1155 @@
{
Copy link
Member

@TomerGoldfriend TomerGoldfriend Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well, I would say quantum variables {x} instead of bit strings.


Reply via ReviewNB

Copy link
Collaborator Author

@roie-d-classiq roie-d-classiq Dec 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss :),from my understanding {x} are not quantum at all but classical binary variables (i.e. bit strings) changed it to binary array.

algorithms/qaoa/qaoa.ipynb
@@ -0,0 +1,1155 @@
{
Copy link
Member

@TomerGoldfriend TomerGoldfriend Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consisting - maybe defining


Reply via ReviewNB

Copy link
Collaborator Author

@roie-d-classiq roie-d-classiq Dec 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified to: state..., which constitutes the ground state of the mixer Hamiltonian, is that better? a state defining the ground state sound weird to me

algorithms/qaoa/qaoa.ipynb
@@ -0,0 +1,1155 @@
{
Copy link
Member

@TomerGoldfriend TomerGoldfriend Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: use "binary array" instead of bitstring.


Reply via ReviewNB

Copy link
Collaborator Author

@roie-d-classiq roie-d-classiq Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepted...

TomerGoldfriend
TomerGoldfriend approved these changes Dec 17, 2025
View reviewed changes
Copy link
Member

@TomerGoldfriend TomerGoldfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

@roie-d-classiq roie-d-classiq merged commit ed9a4ea into main Dec 29, 2025
6 checks passed
@roie-d-classiq roie-d-classiq deleted the qaoa branch December 29, 2025 13:23
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

🚂 Incredible, @roie-d-classiq! You've merged your 12th PR! 🎯🎊

Your ongoing commitment to classiq-library is truly remarkable. You're a driving force in our community! 🚀
Your contributions are helping to shape the future of quantum computing! What exciting features or improvements do you envision next? 🔮

We are grateful for your dedication! 💫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomerGoldfriend TomerGoldfriend TomerGoldfriend approved these changes

Assignees

No one assigned

Labels

new notebook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roie-d-classiq @TomerGoldfriend