Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
🔥 New notebook just dropped! @amir-naveh , @TomerGoldfriend — come check out this shiny new addition to our repo. |
| @@ -0,0 +1,1158 @@ | |||
| { | |||
There was a problem hiding this comment.
- Output: Approximation of the ground state and energy of H.
- ansats --> ansatze? (I think ansatz in plural is ansatze).
- I would write somewhere here explicitly that ADAPT-VQE is still an approximated and heuristic algorithm (meaning, there is no guarantee it will converge).
- Concerning Complexity: there are many ways to define a complexity... here this is a cost of what? maybe write explicitly that this is the number of observable estimations, and then add that the time/gate complexity of each estimation depends on the operator itself and the details of the ansatz?
Reply via ReviewNB
There was a problem hiding this comment.
Fixed all the comments
| @@ -0,0 +1,1158 @@ | |||
| { | |||
There was a problem hiding this comment.
Note that when multiple quantum computers are available, the preparation of the trial state and measurement of the commutation relations with the Hamiltonian can be performed in parallel, substantially reducing the runtime.
This is also true if I have enough qubits on a single quantum computer, right? I can run in parallel on different qubits?
Reply via ReviewNB
There was a problem hiding this comment.
Yes, definitely, added a comment.
| @@ -0,0 +1,1158 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Fixed, should be K (renamed the variables in the middle....)
| @@ -0,0 +1,1158 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1158 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #43. execution_preferences = ExecutionPreferences(
Maybe put this outside of the loop. It is a parameter which is relevant for all iteration.
Reply via ReviewNB
There was a problem hiding this comment.
definitely, done
| @@ -0,0 +1,1158 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #74. # write_qmod(main, name="adapt_vqe", decimal_precision=15, symbolic_only=False)
Remove
Reply via ReviewNB
| @@ -0,0 +1,1158 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
modified...
| @@ -0,0 +1,1158 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, because I fixed the ansatz state. But it gives a worth results (higher energy).
2 participants
PR Description
Some notes
Please make sure that the notebook runs successfully with the latest Classiq version.
Please make sure that you placed the files in an appropriate folder
.ipynband.qmodto be unique across this repository..qmod,.synthesis_options.json,.metadata.jsonIf applicable, please include link to the paper on which the notebook is based, in the notebook itself.
Please use
rebaseon your branch (no merge commits)Please link this PR to the relevant issue
Please make sure to run
pre-commitwhen commiting changesgitin the terminal, make sure to installpre-commitvia runningpip install pre-commitfollowed bypre-commit installpre-commitdocumentationpre-commit.pre-commitmay minorly alter some files. Make sure togit addthe changes done bypre-commit