Restructure algorithms dir#1426
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
orsa-classiq
left a comment
There was a problem hiding this comment.
1 - Some directories hierarchies were flattened. Specifically grover_mixer_qaoa should be directly under search_and_optimization, or you leave it under qaoa, but then create another directory to the regular qaoa.
Also glued trees directory is missing
2 - I think you should remove ground_state_... directory and move its contents to quantum_state_preparation
3 - consider removing the hhl directory (leaving only a single hhl directory under quantum_linear_solvers, as it contains only a single directory). Same for vqls
OK, some of the flattening is due to github, which does not care about redundant hierarchies. I hope that very soon we will have at least two examples per directory.
I prefer to keep it as is. In particular, QPE is not related to quantum_state_preparation.
Thanks! great catch. |
…ace xor implementation
|
🏆 Incredible, @TomerGoldfriend! You've merged your 53th PR! 🎯🎊 Your ongoing commitment to classiq-library is truly remarkable. You're a driving force in our community! 🚀 We are grateful for your dedication! 💫 |
PR Description
This PR restructure the algorithms directory, (including fixing the relevant links in other notebooks)