Skip to content

Restructure algorithms dir#1426

Merged
TomerGoldfriend merged 21 commits intoClassiq:mainfrom
TomerGoldfriend:restructure_algorithms_dir
Jan 13, 2026
Merged

Restructure algorithms dir#1426
TomerGoldfriend merged 21 commits intoClassiq:mainfrom
TomerGoldfriend:restructure_algorithms_dir

Conversation

@TomerGoldfriend
Copy link
Member

PR Description

This PR restructure the algorithms directory, (including fixing the relevant links in other notebooks)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@orsa-classiq orsa-classiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 - Some directories hierarchies were flattened. Specifically grover_mixer_qaoa should be directly under search_and_optimization, or you leave it under qaoa, but then create another directory to the regular qaoa.
Also glued trees directory is missing
2 - I think you should remove ground_state_... directory and move its contents to quantum_state_preparation
3 - consider removing the hhl directory (leaving only a single hhl directory under quantum_linear_solvers, as it contains only a single directory). Same for vqls

@TomerGoldfriend
Copy link
Member Author

1 - Some directories hierarchies were flattened. Specifically grover_mixer_qaoa should be directly under search_and_optimization, or you leave it under qaoa, but then create another directory to the regular qaoa. Also glued trees
directory is missing

OK, some of the flattening is due to github, which does not care about redundant hierarchies. I hope that very soon we will have at least two examples per directory.

2 - I think you should remove ground_state_... directory and move its contents to quantum_state_preparation

I prefer to keep it as is. In particular, QPE is not related to quantum_state_preparation.

3 - consider removing the hhl directory (leaving only a single hhl directory under quantum_linear_solvers, as it contains
only a single directory). Same for vqls

Thanks! great catch.
@orsa-classiq

@TomerGoldfriend TomerGoldfriend merged commit 2934800 into Classiq:main Jan 13, 2026
3 of 5 checks passed
@github-actions
Copy link

🏆 Incredible, @TomerGoldfriend! You've merged your 53th PR! 🎯🎊

Your ongoing commitment to classiq-library is truly remarkable. You're a driving force in our community! 🚀
Your contributions are helping to shape the future of quantum computing! What exciting features or improvements do you envision next? 🔮

We are grateful for your dedication! 💫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants