Add comments to native shor, swap_test, discrete log, hidden shit and simon #1442
Merged
GazitLior1 merged 12 commits intomainfrom Jan 29, 2026
Merged
Add comments to native shor, swap_test, discrete log, hidden shit and simon #1442GazitLior1 merged 12 commits intomainfrom
GazitLior1 merged 12 commits intomainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
algorithms/number_theory_and_cryptography/hidden_shift/hidden_shift.qmod
Outdated
Show resolved
Hide resolved
algorithms/number_theory_and_cryptography/hidden_shift/hidden_shift.qmod
Outdated
Show resolved
Hide resolved
algorithms/number_theory_and_cryptography/hidden_shift/hidden_shift.qmod
Outdated
Show resolved
Hide resolved
roie-d-classiq
approved these changes
Jan 20, 2026
matanvax2
reviewed
Jan 20, 2026
Member
matanvax2
left a comment
matanvax2
left a comment
There was a problem hiding this comment.
I posted a few nitpick English-style comment, and one code structure suggestion
algorithms/number_theory_and_cryptography/discrete_log/discrete_log.qmod
Outdated
Show resolved
Hide resolved
algorithms/number_theory_and_cryptography/hidden_shift/hidden_shift.qmod
Outdated
Show resolved
Hide resolved
algorithms/number_theory_and_cryptography/discrete_log/discrete_log.qmod
Outdated
Show resolved
Hide resolved
GazitLior1
force-pushed
the
native-with-comments
branch
from
697f80d to
8fab893
Compare
|
🔥 Well done @GazitLior1! Two PRs merged already! 🎉🥳 With your second PR, you're on a roll, and your contributions are already making a difference. 🌟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Add comments to native shor, swap_test, discrete log, hidden shit and simon