Skip to content

Great qmods ori#1443

Merged
ori-opher merged 2 commits intomainfrom
great_qmods_ori
Jan 19, 2026
Merged

Great qmods ori#1443
ori-opher merged 2 commits intomainfrom
great_qmods_ori

Conversation

@ori-opher
Copy link
Member

PR Description

Some notes

  • Please use rebase on your branch (no merge commits)

  • Please make sure to run pre-commit when commiting changes

@@ -1,3 +1,13 @@
// Discrete quantum walk on a hypercube

// Perform a discrete quantum walk on a 4-dimensional hypercube, for a t number of steps.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a t number of steps - fix grammer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -1,3 +1,12 @@
// Discrete quantum walk on a circle with a balanced coin

// Perform a discrete quantum walk on a circle (regular 2**N polygon), with a balanced coin, for a t number of steps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the explanation about the quantum walk from the circle qmod also here and in the hypercube

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What explanation? about the coin flip? In the hypercube it's already documented where we pass the coin flip function as an operand, and I also added here at the same spot (when passing the coin flip function)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ori-opher ori-opher merged commit f961f6b into main Jan 19, 2026
6 checks passed
@ori-opher ori-opher deleted the great_qmods_ori branch January 19, 2026 10:28
@github-actions
Copy link

🎊 Great job, @ori-opher! You've merged your 7th PR! 🎊

Your contributions to classiq-library are making a real difference. Keep up the fantastic work! 💪
Remember, every PR counts and helps improve the project. What will you tackle next? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants