Skip to content

update qpe with qubitization example#1446

Merged
TomerGoldfriend merged 1 commit intoClassiq:mainfrom
TomerGoldfriend:update_qpe_with_qubitization
Jan 20, 2026
Merged

update qpe with qubitization example#1446
TomerGoldfriend merged 1 commit intoClassiq:mainfrom
TomerGoldfriend:update_qpe_with_qubitization

Conversation

@TomerGoldfriend
Copy link
Member

PR Description

Updating some code in qpe with qubitization

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@roie-d-classiq roie-d-classiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, I'll approve, note that the energy of "naive qpe" and the "optimized qpe" give the same result up to 10^(-14), that doesn't look right to me, may hint that there is a bug in the presentation of the results.
I can look into it, and understand what is the problem if you want.

@TomerGoldfriend TomerGoldfriend merged commit 4ee63f3 into Classiq:main Jan 20, 2026
3 checks passed
@github-actions
Copy link

🏆 Incredible, @TomerGoldfriend! You've merged your 57th PR! 🎯🎊

Your ongoing commitment to classiq-library is truly remarkable. You're a driving force in our community! 🚀
Your contributions are helping to shape the future of quantum computing! What exciting features or improvements do you envision next? 🔮

We are grateful for your dedication! 💫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants