Shor in library corrected - post-processing#702
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -2,15 +2,15 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
Line #1. from classiq.qmod import QNum, bind, control, within_apply
replace all of the imports to from classiq import *
Reply via ReviewNB
| @@ -2,15 +2,15 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
Line #2. print(result_1.parsed_states)
I think it is better to use result.parsed_counts
Reply via ReviewNB
| @@ -2,15 +2,15 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
powerregister -> missing space
Maybe also add what are you going to factorize here, what is a,etc.
Reply via ReviewNB
| @@ -2,15 +2,15 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
'as expected' - redundant enter after expec
maybe add a reference to the continued fraction algorithm? (e.g wiki page)
Reply via ReviewNB
nadavyoran
force-pushed
the
CAD-22506-shor-modular-exponentiation-correction
branch
from
b6810b6 to
d864324
Compare
|
🔥 Fantastic work @nadavyoran! Your very first PR to classiq-library has been merged! 🎉🥳 If you're feeling adventurous, why not dive into another issue and keep contributing? The Classiq community would love to see more from you! 🚀 Happy coding! 👩💻👨💻 |
classiqdor
deleted the
CAD-22506-shor-modular-exponentiation-correction
branch
2 participants
PR Description
Some notes
Please make sure that you placed the files in an appropriate folder
And that the files have indicative names.
Please note that Classiq runs automatic code linting, which may minorly alter some files.
pre-commit, you may runpre-commit install, and then at each commit, your files will be altered in a similar way