Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
orsa-classiq
approved these changes
Mar 10, 2025
OriRothClassiq
deleted the
Model/OriRothClassiq/remove-symbolic-recursion
branch
|
🚂 Great job, @OriRothClassiq! You've merged your 7th PR! 🎊 Your contributions to classiq-library are making a real difference. Keep up the fantastic work! 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Remove symbolic recursion.
We're changing the way generative functions work. In particular, it would not be possible to define a recursive function using
if_(symbolic if-statement). I've replaced the symbolic if-statement with a Python if-statement.Some notes
Please make sure that you placed the files in an appropriate folder
And that the files have indicative names.
Please note that Classiq runs automatic code linting, which may minorly alter some files.
pre-commit, you may runpre-commit install, and then at each commit, your files will be altered in a similar way