-
Notifications
You must be signed in to change notification settings - Fork 89
V1 model inference with NAIP #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aae436c to
506a664
Compare
c8152a7 to
a0c2852
Compare
1de701f to
3d0ea79
Compare
93f4174 to
d0ec7d9
Compare
64e5479 to
eab6b1f
Compare
|
@lillythomas I think this is a great example, and I think we should polish this up and add to the tutorials. I wanted to ask if you would be up for using |
|
@yellowcap sounds good! I'll work on swapping the method for getting NAIP chips to use stacchip and request your review on it. |
f128b46 to
0c72b7e
Compare
82a68fb to
f0d5691
Compare
48b422d to
fb39e4b
Compare
6e7e393 to
10ba682
Compare
ec327fa to
5844726
Compare
3cac158 to
6bc7665
Compare
efa233b to
fa66a41
Compare
8075f90 to
29a19c6
Compare
yellowcap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! I did a few suggestions, mostly cosmetic changes here #287 .
A few more householding things
- Remove the non-stacchip example,
- Move the tutorial into the tutorials section of the docs (will need and update of the relative paths in the notebook)
- Run the notebook and commit the cells with output, but replace the image with a markdown cell that renders the image that you can upload to the PR. A bit hacky but keeps the repo small.
abf3f6b to
bd24b56
Compare
51dcd4f to
8822fbe
Compare
yellowcap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Just a few small comments, mainly cosmetic things. Feel free to merge when updated.
- Register new notebook to
_toc.yml - add
lancedbto pip install - The cell where chips are downloaded is duplicated, remove older version
- Update relative paths to
../..(notebook requires to levels down) - Centroid extraction can be simplified:
Replace
lon, lat = box(
bounding_box[0], bounding_box[1], bounding_box[2], bounding_box[3]
).centroid.coords[0]
with
lon, lat = bounding_box.centroid.coords[0]
388fa46 to
e6356a6
Compare
6d0c3d9 to
5b9f8e3
Compare
96ff9ee to
0a4ce38
Compare







The purpose of this PR is to create a notebook demonstrating how to run inference on new NAIP scenes. It may also serve the purpose of demonstrating sim search with the generated embeddings.