Fix indexer chip geometry #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was finding largest x_scaling which blew up chip bboxes.
pystac.Item.from_file() now automatically adds 'proj:code' to properties, removes 'proj:epsg' Now passes tests.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_get_trsf_or_shape method was finding highest resolution for shape and lowest for transform (largest x_scaling value). Consequently, chip boundary boxes were being blown up. Fix now finds value corresponding to highest resolution for both shape and transform.
pystac.Item.from_file() now changes proj:epsg attribute to proj:code. Added an elif clause to account for this change.