All Feature's using Feature Flag Hook #324

HYDRO2070 · 2025-03-16T20:40:01Z

No description provided.

vercel · 2025-03-16T20:40:06Z

@HYDRO2070 is attempting to deploy a commit to the thieflord06's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2025-03-16T20:44:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clearsky-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 15, 2025 7:25pm

noahm

the majority of these flags are associated with specific queries the app makes, but as coded here, a disabled flag does not prevent the app from making the query. this defeats the whole point of having the flags in the first place.

noahm · 2025-03-17T01:52:21Z

src/detail-panels/account-header/account-header.jsx

@@ -28,6 +29,8 @@ export function AccountHeader({ className, onInfoClick }) {
  const handleHistoryQuery = useHandleHistory(resolved.data?.shortDID);
  const handleHistory = handleHistoryQuery.data?.handle_history;

+  const userPlacement = useFeatureFlag('user-placement')
+
  const placementquery = usePlacement(resolved.data?.shortDID);


the placement flag needs to conditionally disable this query rather than just hiding the ui it displays in

noahm · 2025-03-17T02:03:19Z

src/detail-panels/block-panel-generic/block-panel-generic.jsx

@@ -41,6 +42,8 @@ export function BlockPanelGeneric({
  const blocklistPages = data?.pages || [];
  const blocklist = blocklistPages.flatMap((page) => page.blocklist);
  const count = totalData?.count;
+  const pageName = (className == 'blocked-by-panel') ? 'blocked-by-count' : 'blocking-count';
+  const pageCount = useFeatureFlag(pageName)


likewise, this needs to disable the queries, but those are made elsewhere and passed by props, so this hook needs to be called elsewhere too

noahm · 2025-03-17T03:26:30Z

src/detail-panels/blocked-by-lists/blocked-by-lists-index.jsx

@@ -30,6 +31,7 @@ export function BlockedByLists() {
  const listPages = data?.pages || [];
  const allLists = listPages.flatMap((page) => page.blocklist);
  const filteredLists = !search ? allLists : matchSearch(allLists, search, () => setTick(tick + 1));
+  const listsBlockedByCount = useFeatureFlag('lists-blocked-by-count')


same here as well. should be controlling whether a query is made

noahm · 2025-03-17T03:26:44Z

src/detail-panels/blocking-lists/blocking-lists-index.jsx

@@ -30,7 +31,7 @@ export function BlockingLists() {
  const listPages = data?.pages || [];
  const allLists = listPages.flatMap((page) => page.blocklist);
  const filteredLists = !search ? allLists : matchSearch(allLists, search, () => setTick(tick + 1));
-
+  const listsBlockingCount = useFeatureFlag('lists-blocking-count')


noahm · 2025-03-17T03:30:33Z

src/detail-panels/labeled/index.jsx

@@ -96,6 +97,7 @@ export default function LabeledPanel() {
  const { data: labelers, isLoading: isLoadingLabelers } = useLabelers();

  const { data: labels, isLoading } = useLabeled(did, labelers);
+  const labelsCount = useFeatureFlag('labels-count')


this this is one last api call that wasn't addressed in the last round of changes

noahm · 2025-03-17T03:32:17Z

src/detail-panels/lists/lists.jsx

@@ -29,6 +30,7 @@ export function Lists() {
  const [tick, setTick] = useState(0);
  const search = (searchParams.get('q') || '').trim();
  const [showSearch, setShowSearch] = useState(!!search);
+  const listsOnListCounts = useFeatureFlag('lists-on-list-counts')


noahm · 2025-03-17T03:33:49Z

src/detail-panels/packs/packed.jsx

@@ -30,6 +31,7 @@ export default function Packed() {
  const search = (searchParams.get('q') || '').trim();
  const [tick, setTick] = useState(0);
  const [showSearch, setShowSearch] = useState(!!search);
+  const starterPacksInCount = useFeatureFlag('starter-packs-in-count');


and again here

noahm · 2025-03-17T03:34:00Z

src/detail-panels/packs/packs.jsx

@@ -30,6 +31,7 @@ export function Packs({ created = false }) {
  const [tick, setTick] = useState(0);
  const search = (searchParams.get('q') || '').trim();
  const [showSearch, setShowSearch] = useState(!!search);
+  const starterPacksMadeCount = useFeatureFlag('starter-packs-made-count');


HYDRO2070 · 2025-04-14T19:57:18Z

@noahm Done with the changes here. Please review it. (Name of the Variable are a bit long. I did it for Understanding Purpose.)
@thieflord06

noahm

This looks much better now. Very close to ready. There's one api call that got overlooked from last time, and two new places where you're now conditionally calling a hook. they should use the same pattern as the others where you can pass an enabled or skip parameter.

noahm · 2025-04-15T03:34:34Z

src/detail-panels/account-header/account-header.jsx

+  const userPlacement = useFeatureFlag('user-placement')
+
+  // call only if userPlacement is true
+  const placementquery = (userPlacement) ? usePlacement(resolved.data?.shortDID) : null;


you cannot conditionally call a hook. this breaks the rules of react hooks.

noahm · 2025-04-15T03:35:27Z

src/detail-panels/account-header/account-extra-info.jsx

+  const ishandleHistory = useFeatureFlag('handle-history')
+
+  // calls only if ishandleHistory is true
+  const handleHistoryQuery = (ishandleHistory) ? useHandleHistory(account?.shortDID) : null;


this is also breaking the rules of hooks

noahm · 2025-04-15T03:36:49Z

src/detail-panels/labeled/index.jsx

@@ -96,6 +97,7 @@ export default function LabeledPanel() {
  const { data: labelers, isLoading: isLoadingLabelers } = useLabelers();

  const { data: labels, isLoading } = useLabeled(did, labelers);
+  const labelsCount = useFeatureFlag('labels-count')


this this is one last api call that wasn't addressed in the last round of changes

HYDRO2070 · 2025-04-15T19:11:22Z

@noahm @thieflord06
Done.

Regarding the label count: the API is fetching all the labels, not just calling it for the count. If we were to stop that call, the labels wouldn't be fetched at all—which we don’t want.

Signed-off-by: Shashank pandey <[email protected]>

noahm

You're totally right about the labels count, my apologies. (Seems like a completely pointless flag for us to have in that case) This looks good to go now!

thieflord06 · 2025-04-29T01:03:20Z

From testing it looks like the counts aren't behaving correctly when not enabled.

lists-blocking-count
blocked-by-count
blocking-count
lists-on-count
lists-blocked-by-count
lists-on-list-counts
starter-packs-in-count
labels-count

Labels-count is the only one I've been able to confirm is working as expected.

All Feature's using Feature Flag Hook

c38903a

vercel bot deployed to Preview March 16, 2025 20:45 View deployment

thieflord06 requested review from thieflord06 and noahm March 16, 2025 21:33

noahm requested changes Mar 17, 2025

View reviewed changes

Optimize feature flag to skip unnecessary fetches

d21e848

vercel bot deployed to Preview April 14, 2025 19:52 View deployment

noahm requested changes Apr 15, 2025

View reviewed changes

Remove Conditional Hook to Simplify Logic

859fe9f

vercel bot deployed to Preview April 15, 2025 19:08 View deployment

Merge branch 'dev' into dev

3b8b6e2

Signed-off-by: Shashank pandey <[email protected]>

vercel bot deployed to Preview April 15, 2025 19:25 View deployment

noahm approved these changes Apr 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

All Feature's using Feature Flag Hook #324

All Feature's using Feature Flag Hook #324

HYDRO2070 commented Mar 16, 2025

vercel bot commented Mar 16, 2025

vercel bot commented Mar 16, 2025 •

edited

Loading

noahm left a comment

noahm Mar 17, 2025

noahm Mar 17, 2025

noahm Mar 17, 2025

noahm Mar 17, 2025

noahm Mar 17, 2025

noahm Apr 15, 2025

noahm Mar 17, 2025

noahm Mar 17, 2025

noahm Mar 17, 2025

HYDRO2070 commented Apr 14, 2025 •

edited

Loading

noahm left a comment

noahm Apr 15, 2025

noahm Apr 15, 2025

noahm Apr 15, 2025

HYDRO2070 commented Apr 15, 2025

noahm left a comment

thieflord06 commented Apr 29, 2025

All Feature's using Feature Flag Hook #324

Are you sure you want to change the base?

All Feature's using Feature Flag Hook #324

Conversation

HYDRO2070 commented Mar 16, 2025

vercel bot commented Mar 16, 2025

vercel bot commented Mar 16, 2025 • edited Loading

noahm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HYDRO2070 commented Apr 14, 2025 • edited Loading

noahm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HYDRO2070 commented Apr 15, 2025

noahm left a comment

Choose a reason for hiding this comment

thieflord06 commented Apr 29, 2025

vercel bot commented Mar 16, 2025 •

edited

Loading

HYDRO2070 commented Apr 14, 2025 •

edited

Loading