Update main.cpp to add ADC filters to reduce noise on voltage and current sensor#106
Open
Jahnkeanater wants to merge 8 commits intoClemensElflein:mainfrom
Open
Update main.cpp to add ADC filters to reduce noise on voltage and current sensor#106Jahnkeanater wants to merge 8 commits intoClemensElflein:mainfrom
Jahnkeanater wants to merge 8 commits intoClemensElflein:mainfrom
Conversation
Added an IIR filter with a weight of 90% to the battery voltage, charge voltage, and charging current to reduce the noise in the ADC measurements.
Author
|
With the sample rate being only 10Hz I think a weight of 80% is probably better. |
GPIO23 is connected to the PS pin of the onboard RT6150B-33GQW, if it's LOW (default) it's in PFM mode for best efficiency, if it's HIGH it's in PWM mode for improved ripple but worse efficiency at light loads. PWM mode should improve the ADC noise.
GPIO23 is connected to the PS pin of the onboard RT6150B-33GQW, if it's LOW (default) it's in PFM mode for best efficiency, if it's HIGH it's in PWM mode for improved ripple but worse efficiency at light loads. PWM mode should improve the ADC noise.
Jahnkeanater
commented
Aug 28, 2024
Author
There was a problem hiding this comment.
Putting the power supply into PWM mode by pulling GPIO23 High should also help improve the ADCs.
#75 Removing this since it might actually make the noise worse.
Jahnkeanater
changed the title
Looks like other people have already proved that PWM mode doesn't improve the noise.
Jahnkeanater
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an IIR filter with a weight of 90% to the battery voltage, charge voltage, and charging current to reduce the noise in the ADC measurements.